Use the local TypeScript version when applicable #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors the way that dynamic requires are handled by ensuring that
require(nonAnalyzableExpression)
will always defer to the__non_webpack_require__
. This also allows us to remove the previous hack of the "Not found" context in Webpack doing a fallback to the environment require.The internal loader loads are then altered to use a non-analyzable require to load dynamically in production. Note that this is the sort of feature code splitting would allow us to avoid as it would work naturally with the types of optimizations involved. So that it looks like a hack is simply because we aren't taking advantage of code splitting which would allow it not to be a hack (as in the whole ncc project would be one build as opposed to many then).
This is based to #232 which turned out to be quite a rabbit hole. This can be merged and that one closed as a result.