-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(turbopack): support transform options (#47365)
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors --> ### What? This PR implements a feature for the turbpack to support (partial) transform configuration inherited from ts/jsconfigs, notably for the legacy decorators and jsx runtimes. ### Why? ### How? - Closes WEB-667
- Loading branch information
Showing
5 changed files
with
181 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
packages/next-swc/crates/next-core/src/transform_options.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| use anyhow::Result; | ||
| use turbo_binding::turbopack::{ | ||
| core::{ | ||
| asset::AssetVc, | ||
| resolve::{find_context_file, node::node_cjs_resolve_options, FindContextFileResult}, | ||
| source_asset::SourceAssetVc, | ||
| }, | ||
| ecmascript::typescript::resolve::{read_from_tsconfigs, read_tsconfigs, tsconfig}, | ||
| turbopack::module_options::{ | ||
| DecoratorsKind, DecoratorsOptions, DecoratorsOptionsVc, JsxTransformOptions, | ||
| JsxTransformOptionsVc, TypescriptTransformOptions, TypescriptTransformOptionsVc, | ||
| }, | ||
| }; | ||
| use turbo_tasks_fs::{FileJsonContentVc, FileSystemPathVc}; | ||
|
|
||
| async fn get_typescript_options( | ||
| project_path: FileSystemPathVc, | ||
| ) -> Option<Vec<(FileJsonContentVc, AssetVc)>> { | ||
| let tsconfig = find_context_file(project_path, tsconfig()); | ||
| match *tsconfig.await.ok()? { | ||
| FindContextFileResult::Found(path, _) => Some( | ||
| read_tsconfigs( | ||
| path.read(), | ||
| SourceAssetVc::new(path).into(), | ||
| node_cjs_resolve_options(path.root()), | ||
| ) | ||
| .await | ||
| .ok()?, | ||
| ), | ||
| FindContextFileResult::NotFound(_) => None, | ||
| } | ||
| } | ||
|
|
||
| /// Build the transform options for specifically for the typescript's runtime | ||
| /// outputs | ||
| #[turbo_tasks::function] | ||
| pub async fn get_typescript_transform_options( | ||
| project_path: FileSystemPathVc, | ||
| ) -> Result<TypescriptTransformOptionsVc> { | ||
| let tsconfig = get_typescript_options(project_path).await; | ||
|
|
||
| let use_define_for_class_fields = if let Some(tsconfig) = tsconfig { | ||
| read_from_tsconfigs(&tsconfig, |json, _| { | ||
| json["compilerOptions"]["useDefineForClassFields"].as_bool() | ||
| }) | ||
| .await? | ||
| .unwrap_or(false) | ||
| } else { | ||
| false | ||
| }; | ||
|
|
||
| let ts_transform_options = TypescriptTransformOptions { | ||
| use_define_for_class_fields, | ||
| }; | ||
|
|
||
| Ok(ts_transform_options.cell()) | ||
| } | ||
|
|
||
| /// Build the transform options for the decorators. | ||
| /// [TODO]: Currnently only typescript's legacy decorators are supported | ||
| #[turbo_tasks::function] | ||
| pub async fn get_decorators_transform_options( | ||
| project_path: FileSystemPathVc, | ||
| ) -> Result<DecoratorsOptionsVc> { | ||
| let tsconfig = get_typescript_options(project_path).await; | ||
|
|
||
| let decorators_transform_options = if let Some(tsconfig) = tsconfig { | ||
| read_from_tsconfigs(&tsconfig, |json, _| { | ||
| let decorators_kind = if json["compilerOptions"]["experimentalDecorators"] | ||
| .as_bool() | ||
| .unwrap_or(false) | ||
| { | ||
| Some(DecoratorsKind::Legacy) | ||
| } else { | ||
| // ref: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-rc/#differences-with-experimental-legacy-decorators | ||
| // `without the flag, decorators will now be valid syntax for all new code. | ||
| // Outside of --experimentalDecorators, they will be type-checked and emitted | ||
| // differently with ts 5.0, new ecma decorators will be enabled | ||
| // if legacy decorators are not enabled | ||
| Some(DecoratorsKind::Ecma) | ||
| }; | ||
|
|
||
| let emit_decorators_metadata = if let Some(decorators_kind) = &decorators_kind { | ||
| match decorators_kind { | ||
| DecoratorsKind::Legacy => { | ||
| // ref: This new decorators proposal is not compatible with | ||
| // --emitDecoratorMetadata, and it does not allow decorating parameters. | ||
| // Future ECMAScript proposals may be able to help bridge that gap | ||
| json["compilerOptions"]["emitDecoratorMetadata"] | ||
| .as_bool() | ||
| .unwrap_or(false) | ||
| } | ||
| DecoratorsKind::Ecma => false, | ||
| } | ||
| } else { | ||
| false | ||
| }; | ||
|
|
||
| Some(DecoratorsOptions { | ||
| decorators_kind, | ||
| emit_decorators_metadata, | ||
| use_define_for_class_fields: json["compilerOptions"]["useDefineForClassFields"] | ||
| .as_bool() | ||
| .unwrap_or(false), | ||
| ..Default::default() | ||
| }) | ||
| }) | ||
| .await? | ||
| .unwrap_or_default() | ||
| } else { | ||
| Default::default() | ||
| }; | ||
|
|
||
| Ok(decorators_transform_options.cell()) | ||
| } | ||
|
|
||
| #[turbo_tasks::function] | ||
| pub async fn get_jsx_transform_options( | ||
| project_path: FileSystemPathVc, | ||
| ) -> Result<JsxTransformOptionsVc> { | ||
| let tsconfig = get_typescript_options(project_path).await; | ||
|
|
||
| let react_transform_options = if let Some(tsconfig) = tsconfig { | ||
| read_from_tsconfigs(&tsconfig, |json, _| { | ||
| let jsx_import_source = json["compilerOptions"]["jsxImportSource"] | ||
| .as_str() | ||
| .map(|s| s.to_string()); | ||
|
|
||
| // interop between tsconfig's jsx to swc's jsx runtime configuration. Swc's jsx | ||
| // runtime is a subset of tsconfig's jsx. | ||
| let runtime = if let Some(jsx_runtime) = json["compilerOptions"]["jsx"].as_str() { | ||
| match jsx_runtime { | ||
| "react" => Some("classic".to_string()), | ||
| "react-jsx" => Some("automatic".to_string()), | ||
| "react-jsxdev" => Some("automatic".to_string()), | ||
| _ => None, | ||
| } | ||
| } else { | ||
| None | ||
| }; | ||
|
|
||
| Some(JsxTransformOptions { | ||
| import_source: jsx_import_source, | ||
| runtime, | ||
| }) | ||
| }) | ||
| .await? | ||
| .unwrap_or_default() | ||
| } else { | ||
| Default::default() | ||
| }; | ||
|
|
||
| Ok(react_transform_options.cell()) | ||
| } |
This file was deleted.
Oops, something went wrong.