Skip to content

Commit

Permalink
Module ID strategies tests
Browse files Browse the repository at this point in the history
  • Loading branch information
LichuAcu committed Aug 20, 2024
1 parent 1776af0 commit 065474b
Show file tree
Hide file tree
Showing 6 changed files with 133 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import React from 'react'

async function CustomComponent() {
return (
<div>
<h1>the content of a dynamic component</h1>
</div>
)
}

export default CustomComponent
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
foo: 'the content of a module with a long name',
}
4 changes: 4 additions & 0 deletions test/integration/module-id-strategies/next.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
bundlePagesRouterDependencies: true,
serverExternalPackages: ['opted-out-external-package'],
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions test/integration/module-id-strategies/pages/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { foo } from '../module-with-long-name'
import { bar } from '../node_modules/external-module-with-long-name'
import dynamic from 'next/dynamic'

const DynamicCustomComponent = dynamic(
() => import('../components/CustomComponent'),
{
loading: () => <p>Loading...</p>,
}
)

export default function Index() {
return (
<div>
<DynamicCustomComponent />
{foo} {bar}
</div>
)
}
93 changes: 93 additions & 0 deletions test/integration/module-id-strategies/test/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
/* eslint-env jest */

import fs from 'fs-extra'
import { join } from 'path'
import {
killApp,
findPort,
launchApp,
nextBuild,
renderViaHTTP,
} from 'next-test-utils'

const appDir = join(__dirname, '../')

let appPort
let app

describe('minified module ids', () => {
;(!process.env.TURBOPACK || process.env.TURBOPACK_DEV
? describe.skip
: describe)('production mode', () => {
let allBundles = ''

beforeAll(async () => {
await nextBuild(appDir, [])

const ssrPath = join(appDir, '.next/server/chunks/ssr')
const pageBundleBasenames = (await fs.readdir(ssrPath)).filter((p) =>
p.match(/\.js$/)
)
for (const basename of pageBundleBasenames) {
const output = await fs.readFile(join(ssrPath, basename), 'utf8')
allBundles += output
}
})

it('should have no long module ids for basic modules', async () => {
expect(allBundles).not.toContain('module-with-long-name')
expect(allBundles).toContain('the content of a module with a long name')
})

it('should have no long module ids for external modules', async () => {
expect(allBundles).not.toContain('external-module-with-long-name')
expect(allBundles).toContain(
'the content of an external module with a long name'
)
})

it('should have no long module ids for async loader modules', async () => {
expect(allBundles).not.toContain('CustomComponent.tsx')
expect(allBundles).toContain('the content of a dynamic component')
})
})
;(!process.env.TURBOPACK || process.env.TURBOPACK_BUILD
? describe.skip
: describe)('development mode', () => {
let allBundles = ''

beforeAll(async () => {
appPort = await findPort()
app = await launchApp(appDir, appPort)

await renderViaHTTP(appPort, '/')

const ssrPath = join(appDir, '.next/server/chunks/ssr')
const pageBundleBasenames = (await fs.readdir(ssrPath)).filter((p) =>
p.match(/\.js$/)
)
for (const basename of pageBundleBasenames) {
const output = await fs.readFile(join(ssrPath, basename), 'utf8')
allBundles += output
}
})
afterAll(() => killApp(app))

it('should have long module ids for basic modules', async () => {
expect(allBundles).toContain('module-with-long-name')
expect(allBundles).toContain('the content of a module with a long name')
})

it('should have long module ids for external modules', async () => {
expect(allBundles).toContain('external-module-with-long-name')
expect(allBundles).toContain(
'the content of an external module with a long name'
)
})

it('should have long module ids for async loader modules', async () => {
expect(allBundles).toContain('CustomComponent.tsx')
expect(allBundles).toContain('the content of a dynamic component')
})
})
})

0 comments on commit 065474b

Please sign in to comment.