Skip to content

Commit

Permalink
Bump installed React
Browse files Browse the repository at this point in the history
rc.0 and latest rc have diverged significantly that support of rc.0 in pages router is no longer guaranteed.
  • Loading branch information
eps1lon committed Jul 22, 2024
1 parent c48e037 commit 1c12dde
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 12 deletions.
4 changes: 2 additions & 2 deletions examples/reproduction-template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
},
"dependencies": {
"next": "canary",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0"
"react": "19.0.0-rc-dfd30974ab-20240613",
"react-dom": "19.0.0-rc-dfd30974ab-20240613"
},
"devDependencies": {
"@types/node": "20.12.12",
Expand Down
4 changes: 2 additions & 2 deletions packages/create-next-app/templates/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ export const installTemplate = async ({
* Default dependencies.
*/
dependencies: {
react: "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0",
react: "19.0.0-rc-dfd30974ab-20240613",
"react-dom": "19.0.0-rc-dfd30974ab-20240613",
next: version,
},
devDependencies: {},
Expand Down
4 changes: 2 additions & 2 deletions packages/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@
"@opentelemetry/api": "^1.1.0",
"@playwright/test": "^1.41.2",
"babel-plugin-react-compiler": "*",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0",
"react": "19.0.0-rc-dfd30974ab-20240613",
"react-dom": "19.0.0-rc-dfd30974ab-20240613",
"sass": "^1.3.0"
},
"peerDependenciesMeta": {
Expand Down
3 changes: 2 additions & 1 deletion run-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,8 @@ ${ENDGROUP}`)
// a starter Next.js install to re-use to speed up tests
// to avoid having to run yarn each time
console.log(`${GROUP}Creating Next.js install for isolated tests`)
const reactVersion = process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0'
const reactVersion =
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-dfd30974ab-20240613'
const { installDir, pkgPaths, tmpRepoDir } = await createNextInstall({
parentSpan: mockTrace(),
dependencies: {
Expand Down
4 changes: 2 additions & 2 deletions test/.stats-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"license": "MIT",
"dependencies": {
"next": "latest",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0"
"react": "19.0.0-rc-dfd30974ab-20240613",
"react-dom": "19.0.0-rc-dfd30974ab-20240613"
},
"engines": {
"node": ">=18.18.0"
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/next-test/first-time-setup-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
"dependencies": {
"next": "canary",
"react": "19.0.0-rc.0",
"react-dom": "19.0.0-rc.0"
"react": "19.0.0-rc-dfd30974ab-20240613",
"react-dom": "19.0.0-rc-dfd30974ab-20240613"
}
}
2 changes: 1 addition & 1 deletion test/lib/next-modes/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export class NextInstance {
)

const reactVersion =
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc.0'
process.env.NEXT_TEST_REACT_VERSION || '19.0.0-rc-dfd30974ab-20240613'
const finalDependencies = {
react: reactVersion,
'react-dom': reactVersion,
Expand Down

0 comments on commit 1c12dde

Please sign in to comment.