Skip to content

Commit

Permalink
test: disable flaky duration assertion in image optimizer test (#67608)
Browse files Browse the repository at this point in the history
This assertion flakes all the time, so I'd say that it it's not actually
checking anything useful. I think it's better to disable this and save
everyone some reruns
  • Loading branch information
lubieowoce authored Jul 9, 2024
1 parent 1c1dc47 commit 46a915e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/integration/image-optimizer/test/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ export function runTests(ctx: RunTestsCtx) {
query,
opts
)
expect(five.duration).toBeLessThan(one.duration)
// expect(five.duration).toBeLessThan(one.duration) // TODO: investigate why this timing varies randomly
expect(five.res.status).toBe(200)
expect(five.res.headers.get('X-Nextjs-Cache')).toBe('HIT')
expect(five.res.headers.get('Content-Type')).toBe('image/webp')
Expand Down Expand Up @@ -1144,7 +1144,7 @@ export function runTests(ctx: RunTestsCtx) {
query,
opts
)
expect(five.duration).toBeLessThan(one.duration)
// expect(five.duration).toBeLessThan(one.duration) // TODO: investigate why this timing varies randomly
expect(five.res.status).toBe(200)
expect(five.res.headers.get('X-Nextjs-Cache')).toBe('HIT')
expect(five.res.headers.get('Content-Type')).toBe('image/webp')
Expand Down

0 comments on commit 46a915e

Please sign in to comment.