Updates tests due to unflagged sync stack traces

vercel · Oct 16, 2024 · 5fafe44 · 5fafe44
1 parent 929b6d8
commit 5fafe44
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 14 deletions.
diff --git a/test/development/acceptance-app/ReactRefreshLogBox.test.ts b/test/development/acceptance-app/ReactRefreshLogBox.test.ts
@@ -852,7 +852,17 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
       const stackFrames = await Promise.all(
         stackFrameElements.map((f) => f.innerText())
       )
-      expect(stackFrames).toEqual([])
+      expect(stackFrames).toEqual(
+        // TODO: Show useful stack
+        [
+          // Internal frames of React.
+          // Feel free to adjust until we show useful stacks.
+          '',
+          '',
+          '',
+          '',
+        ]
+      )
     } finally {
       await cleanup()
     }
@@ -909,12 +919,26 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
                 Page
                 app/page.js (5:6)
               `,
+              // TODO: Show useful stack
+              // Internal frames of React.
+              // Feel free to adjust until we show useful stacks.
+              '',
+              '',
+              '',
+              '',
             ]
           : [
               outdent`
                 Page
                 app/page.js (5:5)
               `,
+              // TODO: Show useful stack
+              // Internal frames of React.
+              // Feel free to adjust until we show useful stacks.
+              '',
+              '',
+              '',
+              '',
             ]
       )
     } finally {
@@ -957,7 +981,17 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
       const stackFrames = await Promise.all(
         stackFrameElements.map((f) => f.innerText())
       )
-      expect(stackFrames).toEqual([])
+      expect(stackFrames).toEqual(
+        // TODO: Show useful stack
+        [
+          // Internal frames of React.
+          // Feel free to adjust until we show useful stacks.
+          '',
+          '',
+          '',
+          '',
+        ]
+      )
     } finally {
       await cleanup()
     }

diff --git a/test/development/app-dir/dynamic-error-trace/index.test.ts b/test/development/app-dir/dynamic-error-trace/index.test.ts
@@ -6,8 +6,6 @@ import {
 } from 'next-test-utils'
 import { outdent } from 'outdent'
 
-const isReactExperimental = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
-
 describe('app dir - dynamic error trace', () => {
   const { next, skipped } = nextTestSetup({
     files: __dirname,
@@ -48,16 +46,14 @@ describe('app dir - dynamic error trace', () => {
     )
     expect(stackFrames).toEqual(
       // TODO: Show useful stack
-      isReactExperimental
-        ? [
-            // Internal frames of React.
-            // Feel free to adjust until we show useful stacks.
-            '',
-            '',
-            '',
-            '',
-          ]
-        : []
+      [
+        // Internal frames of React.
+        // Feel free to adjust until we show useful stacks.
+        '',
+        '',
+        '',
+        '',
+      ]
     )
 
     const codeframe = await getRedboxSource(browser)