Skip to content

Commit

Permalink
Add warning when parent styles will break next/image
Browse files Browse the repository at this point in the history
  • Loading branch information
styfle committed Aug 17, 2021
1 parent fe246ba commit 76ed6cd
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 1 deletion.
18 changes: 17 additions & 1 deletion packages/next/client/image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ function defaultImageLoader(loaderProps: ImageLoaderProps) {
function handleLoading(
img: HTMLImageElement | null,
src: string,
layout: LayoutValue,
placeholder: PlaceholderValue,
onLoadingComplete?: OnLoadingComplete
) {
Expand All @@ -267,6 +268,21 @@ function handleLoading(
// underlying DOM element because it could be misused.
onLoadingComplete({ naturalWidth, naturalHeight })
}
if (process.env.NODE_ENV !== 'production') {
const parentStyle = img.parentElement?.parentElement?.style
if (layout === 'responsive' && parentStyle?.display === 'flex') {
console.warn(
`Image with src "${src}" may not render properly as a child of a flex container. Consider wrapping the image with a div to configure the width.`
)
} else if (
layout === 'fill' &&
parentStyle?.position !== 'relative'
) {
console.warn(
`Image with src "${src}" may not render properly with a parent using position:"${parentStyle?.position}". Consider changing the parent style to position:"relative" with a width and height.`
)
}
}
})
}
}
Expand Down Expand Up @@ -612,7 +628,7 @@ export default function Image({
className={className}
ref={(img) => {
setRef(img)
handleLoading(img, srcString, placeholder, onLoadingComplete)
handleLoading(img, srcString, layout, placeholder, onLoadingComplete)
}}
style={{ ...imgStyle, ...blurStyle }}
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import React from 'react'
import Image from 'next/image'
import img from '../public/test.jpg'

const Page = () => {
return (
<div style={{ position: 'static' }}>
<Image layout="fill" src={img} />
</div>
)
}

export default Page
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import React from 'react'
import Image from 'next/image'
import img from '../public/test.jpg'

const Page = () => {
return (
<div style={{ display: 'flex' }}>
<Image layout="responsive" src={img} />
</div>
)
}

export default Page
27 changes: 27 additions & 0 deletions test/integration/image-component/default/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,33 @@ function runTests(mode) {
)
})

it('should warn when img with layout=responsive is inside flex container', async () => {
const browser = await webdriver(appPort, '/layout-responsive-inside-flex')

const warnings = (await browser.log('browser'))
.map((log) => log.message)
.join('\n')
expect(await hasRedbox(browser)).toBe(false)
expect(warnings).toMatch(
/Image with src (.*)jpg(.*) may not render properly as a child of a flex container. Consider wrapping the image with a div to configure the width/gm
)
})

it('should warn when img with layout=fill is inside a container without position relative', async () => {
const browser = await webdriver(
appPort,
'/layout-fill-inside-nonrelative'
)

const warnings = (await browser.log('browser'))
.map((log) => log.message)
.join('\n')
expect(await hasRedbox(browser)).toBe(false)
expect(warnings).toMatch(
/Image with src (.*)jpg(.*) may not render properly with a parent using position:\"static\". Consider changing the parent style to position:\"relative\"/gm
)
})

it('should warn when using a very small image with placeholder=blur', async () => {
const browser = await webdriver(appPort, '/small-img-import')

Expand Down

0 comments on commit 76ed6cd

Please sign in to comment.