[Backport 15.0] Use React 19 stable (#73564)

vercel · Dec 5, 2024 · 8774088 · 8774088
1 parent 7dc7be2
commit 8774088
Show file tree

Hide file tree

Showing 11 changed files with 21 additions and 43 deletions.
diff --git a/examples/reproduction-template/package.json b/examples/reproduction-template/package.json
@@ -7,8 +7,8 @@
   },
   "dependencies": {
     "next": "canary",
-    "react": "19.0.0-rc-66855b96-20241106",
-    "react-dom": "19.0.0-rc-66855b96-20241106"
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
   },
   "devDependencies": {
     "@types/node": "20.12.12",

diff --git a/package.json b/package.json
@@ -209,10 +209,10 @@
     "pretty-bytes": "5.3.0",
     "pretty-ms": "7.0.0",
     "random-seed": "0.3.0",
-    "react": "19.0.0-rc-66855b96-20241106",
+    "react": "19.0.0",
     "react-17": "npm:react@17.0.2",
     "react-builtin": "npm:react@19.0.0-rc-66855b96-20241106",
-    "react-dom": "19.0.0-rc-66855b96-20241106",
+    "react-dom": "19.0.0",
     "react-dom-17": "npm:react-dom@17.0.2",
     "react-dom-builtin": "npm:react-dom@19.0.0-rc-66855b96-20241106",
     "react-dom-experimental-builtin": "npm:react-dom@0.0.0-experimental-66855b96-20241106",

diff --git a/packages/create-next-app/templates/index.ts b/packages/create-next-app/templates/index.ts
@@ -13,7 +13,7 @@ import { GetTemplateFileArgs, InstallTemplateArgs } from "./types";
 
 // Do not rename or format. sync-react script relies on this line.
 // prettier-ignore
-const nextjsReactPeerVersion = "19.0.0-rc-66855b96-20241106";
+const nextjsReactPeerVersion = "^19.0.0";
 
 /**
  * Get the file path for a given file in a template, e.g. "next.config.js".
@@ -212,8 +212,8 @@ export const installTemplate = async ({
       ...packageJson.devDependencies,
       typescript: "^5",
       "@types/node": "^20",
-      "@types/react": "^18",
-      "@types/react-dom": "^18",
+      "@types/react": "^19",
+      "@types/react-dom": "^19",
     };
   }
 

diff --git a/packages/next/package.json b/packages/next/package.json
@@ -109,8 +109,8 @@
     "@opentelemetry/api": "^1.1.0",
     "@playwright/test": "^1.41.2",
     "babel-plugin-react-compiler": "*",
-    "react": "^18.2.0 || 19.0.0-rc-66855b96-20241106",
-    "react-dom": "^18.2.0 || 19.0.0-rc-66855b96-20241106",
+    "react": "^18.2.0 || 19.0.0-rc-66855b96-20241106 || ^19.0.0",
+    "react-dom": "^18.2.0 || 19.0.0-rc-66855b96-20241106 || ^19.0.0",
     "sass": "^1.3.0"
   },
   "peerDependenciesMeta": {

diff --git a/packages/third-parties/package.json b/packages/third-parties/package.json
@@ -33,6 +33,6 @@
   },
   "peerDependencies": {
     "next": "^13.0.0 || ^14.0.0 || ^15.0.0",
-    "react": "^18.2.0 || 19.0.0-rc-66855b96-20241106"
+    "react": "^18.2.0 || 19.0.0-rc-66855b96-20241106 || ^19.0.0"
   }
 }
diff --git a/run-tests.js b/run-tests.js
@@ -20,7 +20,7 @@ const { getTestFilter } = require('./test/get-test-filter')
 
 // Do not rename or format. sync-react script relies on this line.
 // prettier-ignore
-const nextjsReactPeerVersion = "19.0.0-rc-66855b96-20241106";
+const nextjsReactPeerVersion = "^19.0.0";
 
 let argv = require('yargs/yargs')(process.argv.slice(2))
   .string('type')

diff --git a/test/.stats-app/package.json b/test/.stats-app/package.json
@@ -4,8 +4,8 @@
   "license": "MIT",
   "dependencies": {
     "next": "latest",
-    "react": "19.0.0-rc-66855b96-20241106",
-    "react-dom": "19.0.0-rc-66855b96-20241106"
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
   },
   "engines": {
     "node": ">=18.18.0"

diff --git a/test/e2e/app-dir/rsc-basic/rsc-basic.test.ts b/test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
@@ -7,7 +7,6 @@ import cheerio from 'cheerio'
 // on experimental flags. For example, as a first step we could all the common
 // gates like this one into a single module.
 const isPPREnabledByDefault = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
-const isReact18 = parseInt(process.env.NEXT_TEST_REACT_VERSION) === 18
 
 async function resolveStreamResponse(response: any, onData?: any) {
   let result = ''
@@ -515,14 +514,7 @@ describe('app dir - rsc basics', () => {
       ]
 
       ssrPagesReactVersions.forEach((version) => {
-        if (isReact18 || isPPREnabledByDefault) {
-          expect(version).not.toMatch(bundledReactVersionPattern)
-        } else {
-          // TODO: Pages router only supports React 19 that is bundled
-          // Once we run with React 19 stable, this branch should be removed in
-          // favor of unconditional `not.toMatch`
-          expect(version).toMatch(bundledReactVersionPattern)
-        }
+        expect(version).not.toMatch(bundledReactVersionPattern)
       })
     })
     await Promise.all(promises)
@@ -556,24 +548,10 @@ describe('app dir - rsc basics', () => {
     `)
 
     browserPagesReactVersions.forEach((version) => {
-      if (isReact18 || isPPREnabledByDefault) {
-        expect(version).not.toMatch(bundledReactVersionPattern)
-      } else {
-        // TODO: Pages router only supports React 19 that is bundled
-        // Once we run with React 19 stable, this branch should be removed in
-        // favor of unconditional `not.toMatch`
-        expect(version).toMatch(bundledReactVersionPattern)
-      }
+      expect(version).not.toMatch(bundledReactVersionPattern)
     })
     browserEdgePagesReactVersions.forEach((version) => {
-      if (isReact18 || isPPREnabledByDefault) {
-        expect(version).not.toMatch(bundledReactVersionPattern)
-      } else {
-        // TODO: Pages router only supports React 19 that is bundled
-        // Once we run with React 19 stable, this branch should be removed in
-        // favor of unconditional `not.toMatch`
-        expect(version).toMatch(bundledReactVersionPattern)
-      }
+      expect(version).not.toMatch(bundledReactVersionPattern)
     })
   })
 

diff --git a/test/e2e/next-test/first-time-setup-js/package.json b/test/e2e/next-test/first-time-setup-js/package.json
@@ -8,7 +8,7 @@
   },
   "dependencies": {
     "next": "canary",
-    "react": "19.0.0-rc-66855b96-20241106",
-    "react-dom": "19.0.0-rc-66855b96-20241106"
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
   }
 }
diff --git a/test/e2e/next-test/first-time-setup-ts/package.json b/test/e2e/next-test/first-time-setup-ts/package.json
@@ -8,8 +8,8 @@
   },
   "dependencies": {
     "next": "canary",
-    "react": "19.0.0-rc-66855b96-20241106",
-    "react-dom": "19.0.0-rc-66855b96-20241106"
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
   },
   "devDependencies": {
     "@types/react": "^18",

diff --git a/test/lib/next-modes/base.ts b/test/lib/next-modes/base.ts
@@ -51,7 +51,7 @@ type OmitFirstArgument<F> = F extends (
 
 // Do not rename or format. sync-react script relies on this line.
 // prettier-ignore
-const nextjsReactPeerVersion = "19.0.0-rc-66855b96-20241106";
+const nextjsReactPeerVersion = "^19.0.0";
 
 export class NextInstance {
   protected files: FileRef | { [filename: string]: string | FileRef }