Fix EcmascriptModuleFacadeModule::ident()

vercel · Oct 17, 2024 · b3f74d6 · b3f74d6
1 parent efbab25
commit b3f74d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/turbopack/crates/turbopack-ecmascript/src/side_effect_optimization/facade/module.rs b/turbopack/crates/turbopack-ecmascript/src/side_effect_optimization/facade/module.rs
@@ -1,7 +1,7 @@
 use std::collections::BTreeMap;
 
 use anyhow::{bail, Result};
-use turbo_tasks::Vc;
+use turbo_tasks::{ValueToString, Vc};
 use turbo_tasks_fs::{glob::Glob, File, FileContent};
 use turbopack_core::{
     asset::{Asset, AssetContent},
@@ -61,10 +61,10 @@ impl EcmascriptModuleFacadeModule {
 #[turbo_tasks::value_impl]
 impl Module for EcmascriptModuleFacadeModule {
     #[turbo_tasks::function]
-    fn ident(&self) -> Vc<AssetIdent> {
+    async fn ident(&self) -> Result<Vc<AssetIdent>> {
         let inner = self.module.ident();
 
-        inner.with_part(self.ty)
+        Ok(inner.with_modifier(self.ty.to_string()))
     }
 
     #[turbo_tasks::function]

diff --git a/... doesn't exist in target modul-e35178.txt → ... doesn't exist in target modul-66918a.txt b/... doesn't exist in target modul-e35178.txt → ... doesn't exist in target modul-66918a.txt
@@ -8,7 +8,7 @@ error - [bindings] [project]/turbopack/crates/turbopack-tests/tests/execution/tu
        4 | import * as X from "./module";
        5 | 
 
-  The export Abc was not found in module [project]/turbopack/crates/turbopack-tests/tests/execution/turbopack/exports/invalid-export/input/invalid-export/module.js [test] (ecmascript) <exports>.
+  The export Abc was not found in module [project]/turbopack/crates/turbopack-tests/tests/execution/turbopack/exports/invalid-export/input/invalid-export/module.js [test] (ecmascript, exports).
 
   Did you mean to import Abd?