-
Notifications
You must be signed in to change notification settings - Fork 27.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add internal
toDisplayRedbox
and toDisplayCollapsedRedbox
inline …
…snapshot matchers These are meant to replace `assertHasRedbox` over time. We want that every redbox insertion in the future asserts on the full error (message, stack, codeframe) in both browser and terminal. We'll slowly expand usage of these matchers until all use cases are covered at which point the old, granular helpers are removed. The end goal is full confidence in our error display without sacrificing DX for people focused on the error message itself. The downside of inline snapshot matcher that we can't have fine-grained TODO comments. But that's only a concern for the few working on working on the error display infra. The goal here is to encourage using these helpers so the priorities of the few working on error infra is lowest. The most annoying fact is the need for forking assertions between Turbopack and Webpack. All the more reason for us to fix the off-by-one column issues between Turbopack and Webpack.
- Loading branch information
Showing
11 changed files
with
731 additions
and
593 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
test/development/acceptance/__snapshots__/ReactRefreshLogBox.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.