Turbopack HMR: url-encode sourceURLs (vercel/turborepo#7682)

Previously, URLs with spaces (such as those with `[root of dev server]`) were not understood by tools like Chrome’s dev tools. Test Plan: Test with an upcoming Next.js PR (to be linked below) Closes PACK-2699
vercel · Mar 9, 2024 · f270e54 · f270e54
1 parent a385cc9
commit f270e54
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/crates/turbopack-ecmascript-runtime/js/src/dev/runtime/dom/runtime-backend-dom.ts b/crates/turbopack-ecmascript-runtime/js/src/dev/runtime/dom/runtime-backend-dom.ts
@@ -288,7 +288,9 @@ async function loadWebAssemblyModule(
 })();
 
 function _eval({ code, url, map }: EcmascriptModuleEntry): ModuleFactory {
-  code += `\n\n//# sourceURL=${location.origin}/${CHUNK_BASE_PATH}${url}`;
+  code += `\n\n//# sourceURL=${encodeURI(
+    location.origin + CHUNK_BASE_PATH + url
+  )}`;
   if (map)
     code += `\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,${btoa(
       map

diff --git a/...ut/79fb1_turbopack-tests_tests_snapshot_runtime_default_dev_runtime_input_index_40d141.js b/...ut/79fb1_turbopack-tests_tests_snapshot_runtime_default_dev_runtime_input_index_40d141.js
diff --git a/...9fb1_turbopack-tests_tests_snapshot_runtime_default_dev_runtime_input_index_40d141.js.map b/...9fb1_turbopack-tests_tests_snapshot_runtime_default_dev_runtime_input_index_40d141.js.map