Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Improve testing #1186

Closed
sakulstra opened this issue Feb 17, 2017 · 2 comments
Closed

[RFC] Improve testing #1186

sakulstra opened this issue Feb 17, 2017 · 2 comments

Comments

@sakulstra
Copy link
Contributor

sakulstra commented Feb 17, 2017

Hello,
currently we have a lot of examples(37 as for today) without any tests in the codebase which break from time to time. As most people will probably try to get started with one of the examples this is suboptimal.

I'd like to help improve this, but i'm not quiet sure where/how to start. We could probably add render tests to check if the application renders without errors for all the examples, but then we had to run yarn install/npm build 37+ times and we would still only catch "big errors" ;)? Any ideas? Eventually this doesn't make sense at all and we should better just improve the core tests? e.g. add tests for react-patch?

@arunoda
Copy link
Contributor

arunoda commented Feb 20, 2017

@sakulstra This is a good point. I think we could simply use our core test tooling for this.
See the test directory of these apps: https://github.com/zeit/next.js/tree/master/test/integration

One question is this might actually slow down the test time. One option is to use travis's parallel testing. (With diff env vars)

@timneutkens
Copy link
Member

I'm going to close this due to inactivity. One thing Arunoda and me talked about is moving the examples into their own repository.

@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants