Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure redirect and notFound return values are documented #18691

Closed
ijjk opened this issue Nov 2, 2020 · 1 comment · Fixed by #18690
Closed

Ensure redirect and notFound return values are documented #18691

ijjk opened this issue Nov 2, 2020 · 1 comment · Fixed by #18690
Assignees
@ijjk
Milestone
iteration 11

Comments

@ijjk
Copy link
Member

ijjk commented Nov 2, 2020

We should make sure these new return values are documented for getStaticProps and getServerSideProps

x-ref: #16642
x-ref: #18241
@ijjk ijjk self-assigned this Nov 2, 2020
@ijjk ijjk added this to the iteration 11 milestone Nov 2, 2020
@ijjk ijjk mentioned this issue Nov 2, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #18690 Nov 2, 2020
kodiakhq bot pushed a commit to ijjk/next.js that referenced this issue Nov 2, 2020
@ijjk
Update redirect and notFound GS(S)P documentation (vercel#18690)
ee6b7ca 
This updates the documentation with the new `redirect` and `notFound` return values adding `redirect` to the `getStaticProps` section and adding a new section describing the return values allowed for `getServerSideProps`

Closes: vercel#18626
Closes: vercel#18691
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Update redirect and notFound GS(S)P documentation ijjk/next.js
3 participants
@Timer @balazsorban44 @ijjk