Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can support egg.js? #2874

Closed
1 task
MinJieLiu opened this issue Aug 31, 2017 · 3 comments
Closed
1 task

Can support egg.js? #2874

MinJieLiu opened this issue Aug 31, 2017 · 3 comments

Comments

@MinJieLiu
Copy link

MinJieLiu commented Aug 31, 2017

  • I have searched the issues of this repository and believe that this is not a duplicate.

egg.js: https://github.com/eggjs/egg

In this example: https://github.com/zeit/next.js/blob/master/examples/custom-server-koa/server.js. ctx.respond = false causes a large number of koa middleware to be invalid. egg.js is based onkoa implementation.

Expected Behavior

Current Behavior

Steps to Reproduce (for bugs)

Context

Your Environment

Tech Version
next v3
node 8.4
OS mac
browser *
etc
@arunoda
Copy link
Contributor

arunoda commented Aug 31, 2017

May be there will be ways to use with koa as it should have done.

Basically to render page we return a promise. So, you need to wait until that.

Not an expert on koa, but I guess it's doable.

Closing this but feel free to discuss. Reopen or ping me if there is something needs from the core.

@arunoda arunoda closed this as completed Aug 31, 2017
@MinJieLiu
Copy link
Author

eggjs/egg#328

@yangchongduo
Copy link

@MinJieLiu Are you sure that the middleware is not working? Give a demo

@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants