Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intercepting routes dose not work when importing client component(13.4.10 breaks) #52681

Closed
1 task done
tangye1234 opened this issue Jul 14, 2023 · 8 comments · Fixed by #52961
Closed
1 task done

Intercepting routes dose not work when importing client component(13.4.10 breaks) #52681

tangye1234 opened this issue Jul 14, 2023 · 8 comments · Fixed by #52961
Labels
bug Issue was opened via the bug report template. locked

Comments

@tangye1234
Copy link
Contributor

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:22 PDT 2023; root:xnu-8796.121.3~7/RELEASE_X86_64
    Binaries:
      Node: 18.16.0
      npm: 9.5.1
      Yarn: 1.22.19
      pnpm: 8.6.3
    Relevant Packages:
      next: 13.4.10
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0
      typescript: N/A
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

App Router

Link to the code that reproduces this issue or a replay of the bug

https://github.com/tangye1234/stackblitz-starters-ktbdbe

To Reproduce

pnpm install

pnpm dev

click the login link, to intercept the /login page

Describe the Bug

Client crash with error said: Error:

Could not find the module "/app/_modal.jsx#Modal" in the React Client Manifest. This is probably a bug in the React Server Components bundler.

Expected Behavior

The next with version between 13.4.5 - 13.4.9 works well with this codes.

13.4.10 / canary dose not.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

selfhost
@tangye1234 tangye1234 added the bug Issue was opened via the bug report template. label Jul 14, 2023
@bessim-dev
Copy link

facing the same exact issue too

@mlmetzner
Copy link

I have the same issue, but I also feel it wasn't working perfectly in version 13.4.9. There was still some weird behavior with search params and the router sometimes not intercepting routes. It works flawlessly with just server components. I have the feeling 13.4.10 just gives a lot more information when errors happen, but it also breaks the routing completely, where before it at least went back to the regular (not intercepted route)

@tangye1234 tangye1234 changed the title Intercepting routes dose not work when importing client component Intercepting routes dose not work when importing client component(13.4.10 breaks) Jul 15, 2023
@Makisuo
Copy link

Makisuo commented Jul 16, 2023

Have been running into the same thing, though it works fine 50% of the time when using for some

@2wheeh
Copy link

2wheeh commented Jul 16, 2023

same. for me especially on safari

@piedrahitapablo piedrahitapablo mentioned this issue Jul 17, 2023
Closed
1 task
@gauravsaini964
Copy link

Same for me.

@tangye1234
Copy link
Contributor Author

@timneutkens This is the reproduction.

@tatwater
Copy link

@isaackoz has a working hypothesis in #52862

ma-chengyuan added a commit to DormSoup/dormsoup that referenced this issue Jul 20, 2023
@ma-chengyuan @andi6558
Attempt to add intercepting routes doesn't really work
210eb0e 
Blocked by vercel/next.js#52681 (comment)

Co-authored-by: Andi Liu <andi6558@users.noreply.github.com>
@shuding shuding mentioned this issue Jul 20, 2023
Merged
FinThunderstorm added a commit to FinThunderstorm/exam-archive-new that referenced this issue Jul 20, 2023
@FinThunderstorm
Create baseline for modals for creating courses, uploading exams and …
433fb88 
…admin tooling like managing courses and exams.

Closing button of modal is commented out and click outside to close is not implemented yet because of vercel/next.js#52681
@FinThunderstorm FinThunderstorm mentioned this issue Jul 20, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #52961 Jul 20, 2023
kodiakhq bot pushed a commit that referenced this issue Jul 20, 2023
@shuding
Fix client reference manifest for interception routes (#52961)
a96a9b0 
We have the logic to group the client compiler's entry names to make sure we generate one single manifest file for the page. This is complicated and requires a special step to "group" the entry names because a page can depend on a bunch of files from everywhere.

And currently, the normalization of "entryName → groupName" doesn't cover interception routes' conventions (`(.)`, `(..)` and `(...)`). This PR fixes that.

Closes #52862, closes #52681, closes #52958.
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix client reference manifest for interception routes vercel/next.js
7 participants
@tangye1234 @tatwater @gauravsaini964 @Makisuo @mlmetzner @2wheeh @bessim-dev