Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/image wrong protocol when in proxy like nginx #55971

Closed
1 task done
joacub opened this issue Sep 25, 2023 · 1 comment · Fixed by #55988
Closed
1 task done

next/image wrong protocol when in proxy like nginx #55971

joacub opened this issue Sep 25, 2023 · 1 comment · Fixed by #55988
Assignees
Labels
bug Issue was opened via the bug report template. Image (next/image) Related to Next.js Image Optimization. invalid link The issue was auto-closed due to a missing/invalid reproduction link. A new issue should be opened.

Comments

@joacub
Copy link

joacub commented Sep 25, 2023

Link to the code that reproduces this issue

no response

To Reproduce

use an nginx proxy and start the server as usuarl using a optimized image component

Current vs. Expected behavior

protoclo dont match with the server protocol, protocol must match the server started protocol

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

13.5.3-canary.4, 13.5.3-canary.3, 13.5.3-canary.2

Which area(s) are affected? (Select all that apply)

Image optimization (next/image, next/legacy/image)

Additional context

invokeRequest(
  `${getRequestMeta(req, '_protocol')}://${
    this.fetchHostname || 'localhost'
  }:${this.port}${newReq.url || ''}`,

that line in the server is matching the request protocol which may or may not match the real server running by next server.

This line should match the protocol have been using by the server not by the request.

@joacub joacub added the bug Issue was opened via the bug report template. label Sep 25, 2023
@github-actions github-actions bot added the Image (next/image) Related to Next.js Image Optimization. label Sep 25, 2023
@github-actions
Copy link
Contributor

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not valid, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link, please open a new issue with a link to a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@github-actions github-actions bot added the invalid link The issue was auto-closed due to a missing/invalid reproduction link. A new issue should be opened. label Sep 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@ztanner ztanner reopened this Sep 25, 2023
@ztanner ztanner self-assigned this Sep 25, 2023
@kodiakhq kodiakhq bot closed this as completed in #55988 Sep 26, 2023
kodiakhq bot pushed a commit that referenced this issue Sep 26, 2023
…rotocol (#55988)

Inferring the protocol from the request meta is not reliable when the next server is running over `http` but sitting behind an https proxy. This instead plumbs the experimental https flag through to the optimizer so we can more reliably determine the protocol

Fixes #55971
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. Image (next/image) Related to Next.js Image Optimization. invalid link The issue was auto-closed due to a missing/invalid reproduction link. A new issue should be opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants