Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: @sentry/profiler-node #60853

Closed
1 task done
JesseKoldewijn opened this issue Jan 18, 2024 · 2 comments · Fixed by #60855
Closed
1 task done

[BUG]: @sentry/profiler-node #60853

JesseKoldewijn opened this issue Jan 18, 2024 · 2 comments · Fixed by #60855
Labels
bug Issue was opened via the bug report template. locked SWC Related to minification/transpilation in Next.js.

Comments

@JesseKoldewijn
Copy link
Contributor

Link to the code that reproduces this issue

https://github.com/JesseKoldewijn/JKinsight

To Reproduce

  1. clone repo
  2. remove Next.js config entry of experimental external package
  3. try to run either dev or build command and see sentry crash due to internal error within bundling process of the @sentry/profiling-node package

Current vs. Expected behavior

current: dev and build cant be run without manually adding external package entry in experimental Next.js config

expected: package can be used without crashing inside bundling process

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Mon Nov 6 23:32:38 UTC 2023
Binaries:
  Node: 18.17.1
  npm: 10.2.5
  Yarn: 1.22.21
  pnpm: 8.14.1
Relevant Packages:
  next: 14.1.1-canary.0
  eslint-config-next: 14.0.4
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.3.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

SWC transpilation

Which stage(s) are affected? (Select all that apply)

next dev (local), next build (local)

Additional context

No response

@JesseKoldewijn JesseKoldewijn added the bug Issue was opened via the bug report template. label Jan 18, 2024
@github-actions github-actions bot added the SWC Related to minification/transpilation in Next.js. label Jan 18, 2024
@JesseKoldewijn
Copy link
Contributor Author

@balazsorban44 hey man sorry for the ping, just wanted to give ya a heads-up that I'm creating a fix for this issue right away in the form of a PR. Beside the issue, hope ya had a great new year's as wel btw! 😄

ijjk pushed a commit that referenced this issue Jan 19, 2024
… breakage (#60855)

Issue: #60853

### What?
Added `@sentry/profiling-node` to the server-external-package object so
that sentry users who want to use this package don't have to manually
add this package in the experimental nextjs config entry.

### Why?
Package bundling will fail as shown in the following issue if not added
to this exclude list.
getsentry/profiling-node#170

---

Fixes #60853
Copy link
Contributor

github-actions bot commented Feb 2, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked SWC Related to minification/transpilation in Next.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant