Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: analytics docs still uses reportWebVitals #62653

Closed
cjimmy opened this issue Feb 28, 2024 · 1 comment · Fixed by #62654
Closed

Docs: analytics docs still uses reportWebVitals #62653

cjimmy opened this issue Feb 28, 2024 · 1 comment · Fixed by #62654
Labels
Documentation Related to Next.js' official documentation. locked

Comments

@cjimmy
Copy link
Contributor

cjimmy commented Feb 28, 2024 •
edited
Loading

What is the improvement or update you wish to see?

The docs for useReportWebVitals has a legacy code example that uses reportWebVitals and to anyone who doesn't know that it's legacy, it's confusing because there's no mention of reportWebVitals anywhere on the page.

Is there any context that might help us understand?

It appears that it was simply missed in this update: #58196

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/pages/api-reference/functions/use-report-web-vitals#custom-metrics
@cjimmy cjimmy added the Documentation Related to Next.js' official documentation. label Feb 28, 2024
cjimmy added a commit to cjimmy/next.js that referenced this issue Feb 28, 2024
@cjimmy
[docs] update analytics doc to use useReportWebVitals (again)
cf01366 
Closes vercel#62653

Finishes the job started by vercel#58196 and updates the last remaining code example that uses `reportWebVitals` to use `useReportWebVitals`
@cjimmy cjimmy mentioned this issue Feb 28, 2024
Merged
samcx added a commit that referenced this issue Feb 28, 2024
@cjimmy @samcx
[docs] update analytics doc to use useReportWebVitals (again) (#62654)
8c242ac 
Closes #62653

Finishes the job started by #58196
and updates the last remaining code example that uses `reportWebVitals`
to use `useReportWebVitals`

Co-authored-by: Sam Ko <sam@vercel.com>
@github-actions GitHub Actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] update analytics doc to use useReportWebVitals (again) cjimmy/next.js
1 participant
@cjimmy