Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: The explanation for "Dynamic Routes" is incorrect. #70124

Closed
hirotomoyamada opened this issue Sep 15, 2024 · 2 comments · Fixed by #70126
Closed

Docs: The explanation for "Dynamic Routes" is incorrect. #70124

hirotomoyamada opened this issue Sep 15, 2024 · 2 comments · Fixed by #70126
Labels
Documentation Related to Next.js' official documentation. locked

Comments

@hirotomoyamada
Copy link
Contributor

What is the documentation issue?

In the "Optional Catch-all Segments", if params is {}, can't reach /shop. The correct value should be { slug: undefined }.

Is there any context that might help us understand?

Just need to change the params from {} to { slug: undefined }.

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/app/building-your-application/routing/dynamic-routes#optional-catch-all-segments
@hirotomoyamada hirotomoyamada added the Documentation Related to Next.js' official documentation. label Sep 15, 2024
@hirotomoyamada hirotomoyamada mentioned this issue Sep 15, 2024
Merged
@ijjk
Copy link
Member

ijjk commented Sep 16, 2024

Closing per #70126 (review)

@ijjk ijjk closed this as completed Sep 16, 2024
ijjk pushed a commit that referenced this issue Sep 17, 2024
@hirotomoyamada
docs: fix 10-dynamic-routes.mdx (#70126)
08f8fac 
params from `{}` to `{ slug: undefined }`.

Fixes #70124
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Oct 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix 10-dynamic-routes.mdx hirotomoyamada/next.js
2 participants
@ijjk @hirotomoyamada