Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Is onRequestError stable? #71634

Closed
rshaul opened this issue Oct 22, 2024 · 2 comments · Fixed by #71649
Closed

Docs: Is onRequestError stable? #71634

rshaul opened this issue Oct 22, 2024 · 2 comments · Fixed by #71649
Labels
Documentation Related to Next.js' official documentation. locked

Comments

@rshaul
Copy link

rshaul commented Oct 22, 2024

What is the documentation issue?

https://nextjs.org/docs/app/api-reference/file-conventions/instrumentation#onrequesterror-optional

onRequestError docs say: This API is available in Next.js canary. in the docs. Which makes me think it is not stable.

Is there any context that might help us understand?

However the blog post states that it is stable.

https://nextjs.org/blog/next-15#instrumentationjs-stable

Not sure which one is correct!

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/app/api-reference/file-conventions/instrumentation#onrequesterror-optional
@rshaul rshaul added the Documentation Related to Next.js' official documentation. label Oct 22, 2024
@samcx
Copy link
Member

samcx commented Oct 22, 2024

@rshaul Thanks for reporting! We are taking a look :frog-eyes:

@huozhi huozhi mentioned this issue Oct 22, 2024
Merged
samcx pushed a commit that referenced this issue Oct 22, 2024
@huozhi
docs: remove the canary note on instrumentation (#71649)
e06cd47 
The note of `onRequestError` API is outdated, it's available on v15
stable now

Fixes #71634
@unstubbable unstubbable mentioned this issue Oct 22, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Nov 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove the canary note on instrumentation vercel/next.js
2 participants
@rshaul @samcx