-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async generator vs syntax transform #851
Comments
Interesting. I'll benchmark changing this. |
Apparently fast-async doesn't support calling await on normal functions that don't return a Promise. So if you, for example make a component which has a |
If there is something else we can look into please let me know 👍 😄 |
Thanks for looking that up. Would be good to give the feedback over there |
@timneutkens I opened an issue over there and there are suggestions on how to fix your concerns: MatAtBread/fast-async#32 (comment) |
To implement this properly we just need to wrap the getInitialProps return value with |
@TooTallNate Fair point. Will have a look into that 👍 |
Going to close this as the fast-async functionality seems to be going to go into babel 7, which we use now for Next.js. |
I don't know much about these things, but was wondering if there's a reason to prefer async generator/regenerator vs. something like fast-async which claims to be 3-4 times faster?
The text was updated successfully, but these errors were encountered: