Add support for params in header key/values #10324

ijjk · 2020-01-29T15:06:05Z

This adds support for using params from the source in header key/values as discussed. It uses the current approach of using compile like normal until we decide how we want to handle patterns with compile here

ijjk · 2020-01-29T15:11:23Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	11.2s	11.1s	-45ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +833 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	11.7s	11.7s	⚠️ +37ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +833 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	5.1 kB	5.1 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.1 kB	4.1 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_error.js gzip	46.6 kB	46.6 kB	✓
404.html gzip	1.42 kB	1.42 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.4 kB	72.4 kB	✓
routerDirect.js gzip	70.4 kB	70.4 kB	✓
withRouter.js gzip	70.5 kB	70.5 kB	✓
Overall change	309 kB	309 kB	✓

Commit: 02ba6e9

# Conflicts: # packages/next/next-server/server/next-server.ts # test/integration/custom-routes/next.config.js # test/integration/custom-routes/test/index.test.js

…/headers-params

ijjk · 2020-03-10T20:35:48Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	9.1s	9.2s	⚠️ +99ms
nodeModulesSize	56.5 MB	56.5 MB	⚠️ +1.08 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..cfaa.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	9.7s	9.7s	-62ms
nodeModulesSize	56.5 MB	56.5 MB	⚠️ +1.08 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..cfaa.js gzip	9.77 kB	9.77 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	18.9 kB	18.9 kB	✓
Overall change	18.9 kB	18.9 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_error.js gzip	293 kB	293 kB	⚠️ +236 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	956 B	956 B	✓
index.js gzip	294 kB	293 kB	-739 B
link.js gzip	301 kB	301 kB	⚠️ +155 B
routerDirect.js gzip	300 kB	300 kB	-111 B
withRouter.js gzip	300 kB	299 kB	-192 B
Overall change	1.49 MB	1.49 MB	-651 B

timneutkens · 2020-04-14T10:05:35Z

test/integration/custom-routes/next.config.js

+              value: 'value=:path',
+            },
+            {
+              key: 'path-:path',


What's the practical case for setting the header name to a dynamic value?

Depending on their set-up a user might want to return the original path as a header for rewrite/proxying scenarios. We mainly added this in @now/routing-utils for consistency so added this here to match that behavior

timneutkens

Lgtm

ijjk · 2020-04-14T16:40:22Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	10.3s	10.7s	⚠️ +373ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +630 B

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.058	2.171	⚠️ +0.11
/ avg req/sec	1214.72	1151.54	-63.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.183	1.211	⚠️ +0.03
/error-in-render avg req/sec	2113.73	2064.5	-49.23

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f272.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
index.html gzip	930 B	930 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
buildDuration	10.8s	10.5s	-280ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +630 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..f272.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js add/headers-params	Change
_error.js	557 kB	557 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	557 kB	557 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	586 kB	586 kB	✓
withRouter.js	586 kB	586 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk added 2 commits January 29, 2020 09:00

Add support for params in header key/values

cd2f8a3

Update todo

02ba6e9

ijjk added this to the 9.2.x milestone Jan 29, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners January 29, 2020 15:06

ijjk and others added 5 commits March 10, 2020 11:13

Merge remote-tracking branch 'upstream/canary' into add/headers-params

ebc5c80

# Conflicts: # packages/next/next-server/server/next-server.ts # test/integration/custom-routes/next.config.js # test/integration/custom-routes/test/index.test.js

Merge branch 'canary' into add/headers-params

080ed29

Merge remote-tracking branch 'upstream/canary' into add/headers-params

32b00bc

Update with handling for named patterns

0d89e7c

Merge branch 'add/headers-params' of github.com:ijjk/next.js into add…

8a4d7f3

…/headers-params

timneutkens added the type: next label Apr 6, 2020

timneutkens reviewed Apr 14, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/canary' into add/headers-params

72d77ef

ijjk requested a review from timneutkens April 14, 2020 16:21

timneutkens approved these changes Apr 14, 2020

View reviewed changes

Use compiled package

1eeb04b

ijjk merged commit ab18c79 into vercel:canary Apr 14, 2020

ijjk deleted the add/headers-params branch April 14, 2020 16:47

This was referenced Apr 17, 2020

[Snyk] Upgrade next from 9.3.4 to 9.3.5 anephenix/ui#4

Merged

[Snyk] Upgrade next from 9.3.4 to 9.3.5 yowainwright/Advanced-React#61

Merged

ykzts mentioned this pull request Apr 19, 2020

Add URL escaping for custom headers #12031

Merged

snyk-bot mentioned this pull request Apr 20, 2020

[Snyk] Upgrade next from 9.3.2 to 9.3.5 tuan231195/sportywide-news#3

Closed

Timer removed this from the 10.x.x milestone Nov 16, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for params in header key/values #10324

Add support for params in header key/values #10324

ijjk commented Jan 29, 2020

ijjk commented Jan 29, 2020

ijjk commented Mar 10, 2020

timneutkens Apr 14, 2020

ijjk Apr 14, 2020

timneutkens left a comment

ijjk commented Apr 14, 2020

Add support for params in header key/values #10324

Add support for params in header key/values #10324

Conversation

ijjk commented Jan 29, 2020

ijjk commented Jan 29, 2020

Stats from current PR

ijjk commented Mar 10, 2020

Stats from current PR

timneutkens Apr 14, 2020

Choose a reason for hiding this comment

ijjk Apr 14, 2020

Choose a reason for hiding this comment

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Apr 14, 2020

Stats from current PR