-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove with-cookie-auth #11865
Merged
timneutkens
merged 1 commit into
vercel:canary
from
lfades:examples/remove-with-cookie-auth
Apr 14, 2020
Merged
Remove with-cookie-auth #11865
timneutkens
merged 1 commit into
vercel:canary
from
lfades:examples/remove-with-cookie-auth
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
|
Checked out the passport example, looks much better than the with-cookie-auth we had before. |
Also https://github.com/zeit/next.js/tree/canary/examples/with-iron-session which brings Rails-like sessions to Next.js:
:p |
@vvo I forgot about that one!, feel welcome to create a PR adding it to the list. |
vvo
added a commit
to vvo/next.js
that referenced
this pull request
Apr 15, 2020
Timer
pushed a commit
that referenced
this pull request
Apr 15, 2020
This was referenced Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example is something we don't and can't recommend to the community as it doesn't have any kind of security measures implemented, we currently have better examples for this so the readme has been updated to recommend those instead.