Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant React imports from with-redux-thunk example #12986

Merged
merged 1 commit into from
May 18, 2020
Merged

Remove redundant React imports from with-redux-thunk example #12986

merged 1 commit into from
May 18, 2020

Conversation

mattcarlotta
Copy link
Contributor

@mattcarlotta mattcarlotta commented May 16, 2020

Removes any redundant import React from "react" imports from the with-redux-thunk example as mentioned in #12964.

That said, I'm not sure if you guys want to remove all redundant React imports from all examples, as this would require some additional documentation about React being partially poly-filled (or imported for JSX files) within next.

@ijjk
Copy link
Member

ijjk commented May 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
buildDuration 12.7s 12.8s ⚠️ +122ms
nodeModulesSize 58.5 MB 58.5 MB
Page Load Tests Overall increase ✓
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
/ failed reqs 0 0
/ total time (seconds) 2.26 2.117 -0.14
/ avg req/sec 1106.37 1180.67 ⚠️ +74.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.465 1.422 -0.04
/error-in-render avg req/sec 1706.73 1758.31 ⚠️ +51.58
Client Bundles (main, webpack, commons)
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
index.html gzip 925 B 925 B
link.html gzip 936 B 936 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode
General
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
buildDuration 13.5s 13.7s ⚠️ +228ms
nodeModulesSize 58.5 MB 58.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
main-HASH.js gzip 6.68 kB 6.68 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
main-HASH.module.js gzip 5.72 kB 5.72 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.28 kB 3.28 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.26 kB 8.26 kB
Client Pages Modern
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.09 kB 2.09 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.38 kB 5.38 kB
Client Build Manifests
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary mattcarlotta/next.js with-redux-thunk Change
_error.js 850 kB 850 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 851 kB 851 kB
link.js 888 kB 888 kB
routerDirect.js 880 kB 880 kB
withRouter.js 880 kB 880 kB
Overall change 4.36 MB 4.36 MB

@Timer Timer added the examples Issue/PR related to examples label May 18, 2020
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@Timer Timer merged commit 3074e5f into vercel:canary May 18, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants