Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove-redundant-example-import #13175

Merged
merged 16 commits into from
May 22, 2020
Merged

chore: remove-redundant-example-import #13175

merged 16 commits into from
May 22, 2020

Conversation

mvfsillva
Copy link
Contributor

This issue is related to #12964

I changed the following examples:
with-zeit-fetch
with-why-did-you-render
with-styletron
custom-server-fastify
custom-server-express
with-why-did-you-render
custom-server-hapi
custom-server-koa
custom-server-polka
custom-server-typescript
progressive-render
ssr-caching
svg-components
using-preact
with-ant-design

@mvfsillva
Removed React redundant import on with-zeit-fetch
d0b7ae3
@mvfsillva
Removed React redundant import on with-why-did-you-render
7009dc7
@mvfsillva
Removed React redundant import on with-styletron
f01dc92
@mvfsillva
Removed React redundant import on custom-server-express
90d0b56
@mvfsillva
Removed React redundant import on custom-server-fastify
5f29823
@mvfsillva
Removed React redundant import on custom-server-hapi
516d795
@mvfsillva
Removed React redundant import on custom-server-koa
5056b17
@mvfsillva
Removed React redundant import on custom-server-polka
497458b
@mvfsillva
Removed React redundant import on custom-server-typescript
c13bf52
@mvfsillva
Removed React redundant import on progressive-render
fffa0f0
@mvfsillva
Removed React redundant import on ssr-caching
28f1483
@mvfsillva
Removed React redundant import on svg-components
44135cc
@mvfsillva
Removed React redundant import on using-preact
f5e3117
@mvfsillva
Removed React redundant import on with-ant-design
5548d51
@ijjk
Copy link
Member

ijjk commented May 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 12.2s 12.1s -154ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.146 2.12 -0.03
/ avg req/sec 1164.93 1179.26 ⚠️ +14.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.332 1.317 -0.02
/error-in-render avg req/sec 1877.54 1897.76 ⚠️ +20.22
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 12.9s 13.1s ⚠️ +138ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 21, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 10.8s 10.9s ⚠️ +145ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.957 1.922 -0.04
/ avg req/sec 1277.67 1300.59 ⚠️ +22.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.263 -0.01
/error-in-render avg req/sec 1963.1 1979.94 ⚠️ +16.84
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 12.3s 11.7s -521ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@rafaelalmeidatk rafaelalmeidatk added the examples Issue/PR related to examples label May 21, 2020
Timer
Timer approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Timer Timer added this to the 9.4.3 milestone May 22, 2020
@ijjk
Copy link
Member

ijjk commented May 22, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 12.5s 12.3s -187ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.171 2.165 -0.01
/ avg req/sec 1151.35 1154.73 ⚠️ +3.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.396 1.341 -0.05
/error-in-render avg req/sec 1791 1863.98 ⚠️ +72.98
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
buildDuration 13.3s 13.2s -139ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary mvfsillva/next.js chore/remove-redundant-example-import Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit 0b94756 into vercel:canary May 22, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@mvfsillva @rokinsky
chore: remove-redundant-example-import (vercel#13175)
89a8623 
This issue is related to vercel#12964 

**I changed the following examples:**
`with-zeit-fetch` 
`with-why-did-you-render`
`with-styletron`
`custom-server-fastify`
`custom-server-express`
`with-why-did-you-render`
`custom-server-hapi`
`custom-server-koa`
`custom-server-polka`
`custom-server-typescript`
`progressive-render`
`ssr-caching`
`svg-components`
`using-preact`
`with-ant-design`
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mvfsillva @ijjk @Timer @rafaelalmeidatk