Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-overmind Server Error due to invalid getStaticProps return statement #13385

Merged
merged 2 commits into from
May 26, 2020
Merged

with-overmind Server Error due to invalid getStaticProps return statement #13385

merged 2 commits into from
May 26, 2020

Conversation

awareness481
Copy link
Contributor

The pages/index.js & pages/index.js files have a return statement in getStaticProps without having a props key causing the app to fail.

Error:
with-overmind-error

Adding a props key removes the error and the app seems to behave as intended. Note that I've never used overmind previously.

@ijjk
Copy link
Member

ijjk commented May 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary awareness481/next.js with-overmind-error Change
buildDuration 10s 10.2s ⚠️ +167ms
nodeModulesSize 66.4 MB 66.4 MB
Page Load Tests Overall increase ✓
zeit/next.js canary awareness481/next.js with-overmind-error Change
/ failed reqs 0 0
/ total time (seconds) 1.892 1.683 -0.21
/ avg req/sec 1321.2 1485.79 ⚠️ +164.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.106 0.968 -0.14
/error-in-render avg req/sec 2259.5 2581.55 ⚠️ +322.05
Client Bundles (main, webpack, commons)
zeit/next.js canary awareness481/next.js with-overmind-error Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..1e23.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary awareness481/next.js with-overmind-error Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary awareness481/next.js with-overmind-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary awareness481/next.js with-overmind-error Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.22 kB 8.22 kB
Client Pages Modern
zeit/next.js canary awareness481/next.js with-overmind-error Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
zeit/next.js canary awareness481/next.js with-overmind-error Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary awareness481/next.js with-overmind-error Change
index.html gzip 927 B 927 B
link.html gzip 937 B 937 B
withRouter.html gzip 924 B 924 B
Overall change 2.79 kB 2.79 kB

Serverless Mode
General
zeit/next.js canary awareness481/next.js with-overmind-error Change
buildDuration 10.7s 10.7s -28ms
nodeModulesSize 66.4 MB 66.4 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary awareness481/next.js with-overmind-error Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..1e23.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary awareness481/next.js with-overmind-error Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary awareness481/next.js with-overmind-error Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary awareness481/next.js with-overmind-error Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.06 kB 2.06 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.22 kB 8.22 kB
Client Pages Modern
zeit/next.js canary awareness481/next.js with-overmind-error Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.52 kB 1.52 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.33 kB 5.33 kB
Client Build Manifests
zeit/next.js canary awareness481/next.js with-overmind-error Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
zeit/next.js canary awareness481/next.js with-overmind-error Change
_error.js 844 kB 844 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 844 kB 844 kB
link.js 882 kB 882 kB
routerDirect.js 874 kB 874 kB
withRouter.js 874 kB 874 kB
Overall change 4.33 MB 4.33 MB

@timneutkens
Copy link
Member

Thanks! 💯

@timneutkens timneutkens merged commit 658e0f8 into vercel:canary May 26, 2020
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
… statement (vercel#13385)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants