-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Error message describing the alternative and added styles… #14652
Updated the Error message describing the alternative and added styles… #14652
Conversation
… css sample code into the err sh link
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: b97e1e2 test/integration/scss/test/index.test.js
Expand output● SCSS Support › Invalid Global CSS › should fail to build
● SCSS Support › Invalid Global CSS with Custom App › should fail to build
● SCSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
test/integration/css/test/index.test.js
Expand output● CSS Support › Invalid Global CSS › should fail to build
● CSS Support › Invalid Global CSS with Custom App › should fail to build
● CSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
|
Failing test suitesCommit: d0fc093 test/integration/dist-dir/test/index.test.js
Expand output● distDir › should handle null/undefined distDir
test/integration/production-build-dir/test/index.test.js
Expand output● Production Custom Build Directory › With basic usage › should render the page
test/integration/scss/test/index.test.js
Expand output● SCSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
test/integration/css/test/index.test.js
Expand output● CSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing test suitesCommit: 126c32e test/integration/scss/test/index.test.js
Expand output● SCSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
test/integration/css/test/index.test.js
Expand output● CSS Support › Valid and Invalid Global CSS with Custom App › should fail to build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the tests?
Stats from current PRDefault Build (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
buildDuration | 17.1s | 16.9s | -185ms |
buildDurationCached | 3.8s | 3.6s | -171ms |
nodeModulesSize | 49.5 MB | 49.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.709 | 2.862 | |
/ avg req/sec | 922.77 | 873.52 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.548 | 1.563 | |
/error-in-render avg req/sec | 1614.62 | 1599.13 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
359.HASH.js gzip | 2.96 kB | 2.96 kB | ✓ |
745.HASH.js gzip | 180 B | 180 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 21 kB | 21 kB | ✓ |
webpack-HASH.js gzip | 1.53 kB | 1.53 kB | ✓ |
Overall change | 67.9 kB | 67.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
_app-HASH.js gzip | 803 B | 803 B | ✓ |
_error-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
amp-HASH.js gzip | 554 B | 554 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
head-HASH.js gzip | 2.28 kB | 2.28 kB | ✓ |
hooks-HASH.js gzip | 903 B | 903 B | ✓ |
image-HASH.js gzip | 5.63 kB | 5.63 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 319 B | 319 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 19.1 kB | 19.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
_buildManifest.js gzip | 489 B | 489 B | ✓ |
Overall change | 489 B | 489 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
index.html gzip | 531 B | 531 B | ✓ |
link.html gzip | 542 B | 542 B | ✓ |
withRouter.html gzip | 525 B | 525 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
buildDuration | 13.1s | 13.4s | |
buildDurationCached | 5.1s | 5.1s | |
nodeModulesSize | 49.5 MB | 49.5 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.839 | 2.856 | |
/ avg req/sec | 880.71 | 875.35 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.553 | 1.492 | -0.06 |
/error-in-render avg req/sec | 1609.28 | 1675.07 | +65.79 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
17.HASH.js gzip | 2.98 kB | 2.98 kB | ✓ |
18.HASH.js gzip | 185 B | 185 B | ✓ |
677f882d2ed8..HASH.js gzip | 13.8 kB | 13.8 kB | ✓ |
framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
main-HASH.js gzip | 8.4 kB | 8.4 kB | ✓ |
webpack-HASH.js gzip | 1.22 kB | 1.22 kB | ✓ |
Overall change | 68.5 kB | 68.5 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
_app-HASH.js gzip | 791 B | 791 B | ✓ |
_error-HASH.js gzip | 3.76 kB | 3.76 kB | ✓ |
amp-HASH.js gzip | 552 B | 552 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
dynamic-HASH.js gzip | 2.71 kB | 2.71 kB | ✓ |
head-HASH.js gzip | 2.97 kB | 2.97 kB | ✓ |
hooks-HASH.js gzip | 911 B | 911 B | ✓ |
index-HASH.js gzip | 231 B | 231 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
script-HASH.js gzip | 3.02 kB | 3.02 kB | ✓ |
withRouter-HASH.js gzip | 294 B | 294 B | ✓ |
e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
Overall change | 17.6 kB | 17.6 kB | ✓ |
Client Build Manifests
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
_buildManifest.js gzip | 500 B | 500 B | ✓ |
Overall change | 500 B | 500 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | brijendravarma/next.js my-errorMsg-contribution | Change | |
---|---|---|---|
index.html gzip | 576 B | 576 B | ✓ |
link.html gzip | 588 B | 588 B | ✓ |
withRouter.html gzip | 569 B | 569 B | ✓ |
Overall change | 1.73 kB | 1.73 kB | ✓ |
vercel#14652) The error message indicates better alternatives and added styles.css sample snippet for good visibility. ![Global_error_msg](https://user-images.githubusercontent.com/38159218/85950309-ac3bc100-b979-11ea-9a8d-4a356cb8007c.JPG) ![CSS-Global](https://user-images.githubusercontent.com/38159218/85950319-b2ca3880-b979-11ea-829a-24335fcfc93d.JPG)
The error message indicates better alternatives and added styles.css sample snippet for good visibility.