Test that cross-page styles do not apply #16129

Timer · 2020-08-12T18:27:55Z

This PR adds a test that ensures styles intended for the current page are applied. This reproduction was provided in #15284.

Fixes #13092
Fixes #15284

ijjk · 2020-08-18T04:17:24Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	11.6s	11.6s	-4ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.986	2.032	⚠️ +0.05
/ avg req/sec	1258.95	1230.14	⚠️ -28.81
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.109	1.059	-0.05
/error-in-render avg req/sec	2254.62	2360.52	+105.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..aa9e.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-c6e605d..8738.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b606df5..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	13.2s	13.3s	⚠️ +82ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..aa9e.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-c6e605d..8738.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.1 kB	57.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-b606df5..dule.js gzip	6.18 kB	6.18 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52 kB	52 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-1464c..a26f.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-00b8972..6e4e.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.7 kB	7.7 kB	✓

Client Pages Modern

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-e550f..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-72c64d9..dule.js gzip	1.27 kB	1.27 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.27 MB	5.27 MB	✓

Commit: e5a8501

ijjk · 2020-08-18T04:43:17Z

Failing test suites

Commit: e5a8501

test/integration/css/test/index.test.js

CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on load)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on hover)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on nav)

Expand output

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on load)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1409 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1410 |         )
> 1411 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1412 |       }
  1413 |       async function checkRebeccaPurpleBackground(browser) {
  1414 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1411:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1424:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on hover)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1409 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1410 |         )
> 1411 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1412 |       }
  1413 |       async function checkRebeccaPurpleBackground(browser) {
  1414 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1411:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1433:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on nav)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1409 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1410 |         )
> 1411 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1412 |       }
  1413 |       async function checkRebeccaPurpleBackground(browser) {
  1414 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1411:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1445:11)

…rder

ijjk · 2021-01-06T15:21:38Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	10.2s	10.5s	⚠️ +253ms
nodeModulesSize	80.8 MB	80.8 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.029	2.101	⚠️ +0.07
/ avg req/sec	1232.38	1189.72	⚠️ -42.66
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.29	1.299	⚠️ +0.01
/error-in-render avg req/sec	1938.47	1925.15	⚠️ -13.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f258db..b7d8.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
index.html gzip	613 B	613 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	12.5s	12.4s	-59ms
nodeModulesSize	80.8 MB	80.8 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f258db..b7d8.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: ca5b882

ijjk · 2021-01-06T15:51:56Z

Failing test suites

Commit: ca5b882

test/integration/css/test/index.test.js

CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on load)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on hover)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on nav)

Expand output

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on load)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1854:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on hover)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1863:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on nav)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1875:11)

ijjk · 2021-01-23T15:25:28Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	8.7s	8.8s	⚠️ +37ms
nodeModulesSize	73.3 MB	73.3 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.724	1.743	⚠️ +0.02
/ avg req/sec	1450.26	1433.95	⚠️ -16.31
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.076	1.123	⚠️ +0.05
/error-in-render avg req/sec	2324.07	2225.53	⚠️ -98.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	10.5s	10.4s	-107ms
nodeModulesSize	73.3 MB	73.3 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode

General

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
buildDuration	10.4s	10.4s	⚠️ +16ms
nodeModulesSize	73.3 MB	73.3 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.729	1.747	⚠️ +0.02
/ avg req/sec	1445.71	1431.27	⚠️ -14.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.097	1.088	-0.01
/error-in-render avg req/sec	2278.73	2296.88	+18.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js hotfix/css-page-order	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "QGaFCXU0ZYN5aOZjNj05p",
+        "buildId": "sKZoqplWMaBCtiGc2WvHj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_buildManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_ssgManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "QGaFCXU0ZYN5aOZjNj05p",
+        "buildId": "sKZoqplWMaBCtiGc2WvHj",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_buildManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_ssgManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "QGaFCXU0ZYN5aOZjNj05p",
+        "buildId": "sKZoqplWMaBCtiGc2WvHj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_buildManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/QGaFCXU0ZYN5aOZjNj05p/_ssgManifest.js"
+      src="/_next/static/sKZoqplWMaBCtiGc2WvHj/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 7124311

ijjk · 2021-01-23T15:45:25Z

Failing test suites

Commit: 7124311

test/integration/css/test/index.test.js

CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on load)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on hover)
CSS Support > CSS Page Ordering > Development Mode > should have correct color on index page (on nav)

Expand output

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on load)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1854:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on hover)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1863:11)

● CSS Support › CSS Page Ordering › Development Mode › should have correct color on index page (on nav)

expect(received).toBe(expected) // Object.is equality

Expected: "rgb(255, 99, 71)"
Received: "rgb(102, 51, 153)"

  1839 |           `window.getComputedStyle(document.querySelector('#hero-home')).backgroundColor`
  1840 |         )
> 1841 |         expect(titleColor).toBe('rgb(255, 99, 71)')
       |                            ^
  1842 |       }
  1843 |       async function checkRebeccaPurpleBackground(browser) {
  1844 |         await browser.waitForElementByCss('#hero-other')

  at checkTomatoBackground (integration/css/test/index.test.js:1841:28)
      at runMicrotasks (<anonymous>)
  at Object.<anonymous> (integration/css/test/index.test.js:1875:11)

jankaifer · 2023-02-01T19:07:16Z

Is this PR still relevant @Timer?

This comment has been minimized.

Sign in to view

Test that cross-page styles do not apply

e5a8501

Timer force-pushed the hotfix/css-page-order branch from fb58952 to e5a8501 Compare August 18, 2020 04:08

Timer added 3 commits January 6, 2021 10:10

temp remove

c51e298

Merge remote-tracking branch 'upstream/canary' into hotfix/css-page-o…

1cd20d0

…rder

re-add test

ca5b882

Merge branch 'canary' into hotfix/css-page-order

7124311

ijjk force-pushed the canary branch 3 times, most recently from df8579c to 47e5ebe Compare October 25, 2022 16:15

ijjk force-pushed the canary branch 2 times, most recently from e078ebe to 6b863fe Compare December 2, 2022 05:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test that cross-page styles do not apply #16129

Test that cross-page styles do not apply #16129

Timer commented Aug 12, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 18, 2020

ijjk commented Aug 18, 2020

ijjk commented Jan 6, 2021

ijjk commented Jan 6, 2021

ijjk commented Jan 23, 2021

Diffs

ijjk commented Jan 23, 2021

jankaifer commented Feb 1, 2023

Test that cross-page styles do not apply #16129

Are you sure you want to change the base?

Test that cross-page styles do not apply #16129

Conversation

Timer commented Aug 12, 2020 • edited Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 18, 2020

Stats from current PR

ijjk commented Aug 18, 2020

Failing test suites

ijjk commented Jan 6, 2021

Stats from current PR

ijjk commented Jan 6, 2021

Failing test suites

ijjk commented Jan 23, 2021

Stats from current PR

Diffs

ijjk commented Jan 23, 2021

Failing test suites

jankaifer commented Feb 1, 2023

Timer commented Aug 12, 2020 •

edited

Loading