Add automatic reloading when editing GS(S)P methods #16744

ijjk · 2020-09-01T06:52:17Z

This adds initial support for reloading the page when getStaticProps, getStaticPaths, or getServerSideProps were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output.

Closes: #13949

ijjk · 2020-09-01T06:59:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	10s	10.1s	⚠️ +89ms
nodeModulesSize	56.8 MB	56.8 MB	⚠️ +5.81 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.828	1.879	⚠️ +0.05
/ avg req/sec	1367.32	1330.38	⚠️ -36.94
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.049	1.049	✓
/error-in-render avg req/sec	2382.58	2382.35	⚠️ -0.23

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..f20b.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-49b1fd5..c64c.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-99715b4..dule.js gzip	6.4 kB	6.4 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.2 kB	52.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
index.html gzip	971 B	971 B	✓
link.html gzip	977 B	977 B	✓
withRouter.html gzip	964 B	964 B	✓
Overall change	2.91 kB	2.91 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	11.4s	11.6s	⚠️ +204ms
nodeModulesSize	56.8 MB	56.8 MB	⚠️ +5.81 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..f20b.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-49b1fd5..c64c.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-99715b4..dule.js gzip	6.4 kB	6.4 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.2 kB	52.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-28298..e0c9.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-000f151..65d4.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-65c8a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-4cfda7a..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	330 B	330 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: f44fa5e

ijjk · 2020-09-01T16:58:08Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	11.6s	12.1s	⚠️ +478ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +5.81 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.116	2.082	-0.03
/ avg req/sec	1181.58	1201.01	+19.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.165	1.161	0
/error-in-render avg req/sec	2145.95	2154.22	+8.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2db3d72..5955.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-d7fe688..dule.js gzip	6.41 kB	6.41 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
index.html gzip	971 B	971 B	✓
link.html gzip	976 B	976 B	✓
withRouter.html gzip	964 B	964 B	✓
Overall change	2.91 kB	2.91 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	13.5s	13.5s	-24ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +5.81 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..9ff9.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-2db3d72..5955.js gzip	7.35 kB	7.35 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-d7fe688..dule.js gzip	6.41 kB	6.41 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-ae98065..267e.js gzip	1.29 kB	1.29 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.69 kB	7.69 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-cb244c4..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.35 kB	5.35 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.07 MB	1.07 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.28 MB	5.28 MB	✓

Commit: 85aab1a

Timer

Let's call router.replace on the current route to refresh the props without throwing away page state!

* feat Export return type for GetStaticPaths * add Duplicate generic Co-authored-by: Luis Alvarez D <luis@vercel.com>

* refactor: remove useless console.log * fix: replace broken images * Updated title Co-authored-by: Luis Alvarez <luis@vercel.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Closes vercel#16538 Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs. This reverts commit ec281df.

…el#16085) This PR is to fix "[Examples] Problem with query parameters in with-redux-persist (vercel#15484)" The root cause is persist/rehydrate action will issue twice when query parameter is set. But persistStore initial bootstrap is not ready yet. So i add a bootstrap callback and force persistor to persist again to make overall state correct. I also modify the loading prop to a `<div>loading</div>` because it's confuse to set Component in loading prop. Attached the GIF ![demo](https://user-images.githubusercontent.com/1462027/89922530-bec04000-dc31-11ea-9831-12cd9d436d96.gif) Closes vercel#15484

This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.

Since the error overlay could be dismissed before this is resolved we need to make sure the component is still mounted before updating the state.

…6360) * Create _document.js Includes the lang attribute with current language inside the <html> tag. * Lint fix Co-authored-by: Luis Alvarez D <luis@vercel.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

…gsp-reloading

ijjk · 2020-09-02T16:36:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	11.2s	11.7s	⚠️ +554ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +6.81 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.093	2.098	0
/ avg req/sec	1194.72	1191.86	⚠️ -2.86
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.271	1.256	-0.01
/error-in-render avg req/sec	1967.62	1991.23	+23.61

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..01b7.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f8f2cfe..033f.js gzip	7.1 kB	7.1 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.39 kB	6.39 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-a6f8e84..dule.js gzip	6.16 kB	6.16 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
index.html gzip	972 B	972 B	✓
link.html gzip	977 B	977 B	✓
withRouter.html gzip	964 B	964 B	✓
Overall change	2.91 kB	2.91 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	12.9s	12.8s	-134ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +6.81 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..01b7.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f8f2cfe..033f.js gzip	7.1 kB	7.1 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.39 kB	6.39 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-a6f8e84..dule.js gzip	6.16 kB	6.16 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 9df55a0

ijjk · 2020-09-02T16:45:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	14.1s	14.1s	-50ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +6.81 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.635	2.572	-0.06
/ avg req/sec	948.62	972.18	+23.56
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.568	1.537	-0.03
/error-in-render avg req/sec	1594.49	1626.42	+31.93

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..01b7.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f8f2cfe..033f.js gzip	7.1 kB	7.1 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.39 kB	6.39 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-a6f8e84..dule.js gzip	6.16 kB	6.16 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
index.html gzip	972 B	972 B	✓
link.html gzip	977 B	977 B	✓
withRouter.html gzip	964 B	964 B	✓
Overall change	2.91 kB	2.91 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
buildDuration	15.6s	15.8s	⚠️ +181ms
nodeModulesSize	55.9 MB	55.9 MB	⚠️ +6.81 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..01b7.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-f8f2cfe..033f.js gzip	7.1 kB	7.1 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
677f882d2ed8..dule.js gzip	6.39 kB	6.39 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-a6f8e84..dule.js gzip	6.16 kB	6.16 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.3 kB	52.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	ijjk/next.js add/gsp-reloading	Change
_error.js	1.03 MB	1.03 MB	✓
404.html	4.22 kB	4.22 kB	✓
hooks.html	3.86 kB	3.86 kB	✓
index.js	1.03 MB	1.03 MB	✓
link.js	1.08 MB	1.08 MB	✓
routerDirect.js	1.07 MB	1.07 MB	✓
withRouter.js	1.07 MB	1.07 MB	✓
Overall change	5.29 MB	5.29 MB	✓

Commit: 498be1b

…16789) This is a follow-up to #16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring Closes: #16790

This adds initial support for reloading the page when `getStaticProps`, `getStaticPaths`, or `getServerSideProps` were changed for a page by triggering a reload when the server output for a page has changed but the client output has not since these methods aren't included in the client output. Closes: vercel#13949

…ercel#16789) This is a follow-up to vercel#16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring Closes: vercel#16790

ijjk added 2 commits September 1, 2020 01:30

Add automatic reloading when editing GS(S)P methods

bd17872

Merge remote-tracking branch 'upstream/canary' into add/gsp-reloading

f44fa5e

ijjk requested review from lfades, Timer and timneutkens as code owners September 1, 2020 06:52

ijjk added the type: next label Sep 1, 2020

Merge branch 'canary' into add/gsp-reloading

85aab1a

Timer requested changes Sep 2, 2020

View reviewed changes

arthurjdam and others added 13 commits September 2, 2020 11:25

Export return type for GetStaticPaths (vercel#16580)

86c6c8b

* feat Export return type for GetStaticPaths * add Duplicate generic Co-authored-by: Luis Alvarez D <luis@vercel.com>

[test] Update hydration marker for React 17 (vercel#16756)

2e0986f

[EXAMPLE] with-framer-motion: fix broken images (vercel#16714)

f3c93e0

* refactor: remove useless console.log * fix: replace broken images * Updated title Co-authored-by: Luis Alvarez <luis@vercel.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Revert vercel#14580 (vercel#16757)

d3cf1ce

v9.5.3-canary.27

9c11d2b

v9.5.3

d723471

Add Fast Refresh Demo (vercel#16576)

936d3f3

Closes vercel#16538 Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs. This reverts commit ec281df.

Make the image post-processor ignore SVG images (vercel#16732)

f7c40c7

This is a small change to the image post-processor logic. When it's looking for images to preload, it will now ignore SVGs, as these are rarely the relevant images for LCP.

v9.5.4-canary.0

d5562f2

Only update lookups for dev overlay if mounted (vercel#16776)

1dd1f70

Since the error overlay could be dismissed before this is resolved we need to make sure the component is still mounted before updating the state.

Update to only re-fetch data instead of reloading

9df55a0

ijjk requested a review from chibicode as a code owner September 2, 2020 16:27

ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: documentation examples Issue/PR related to examples labels Sep 2, 2020

ijjk requested a review from Timer September 2, 2020 16:28

ijjk added 2 commits September 2, 2020 11:34

Update to only re-fetch data instead of reloading

f4031e3

Merge remote-tracking branch 'upstream/canary' into add/gsp-reloading

f642195

ijjk added 2 commits September 2, 2020 11:34

Merge remote-tracking branch 'upstream/canary' into add/gsp-reloading

f41f351

Merge branch 'add/gsp-reloading' of github.com:ijjk/next.js into add/…

498be1b

…gsp-reloading

ijjk removed the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Sep 2, 2020

Timer approved these changes Sep 2, 2020

View reviewed changes

kodiakhq bot merged commit 4685332 into vercel:canary Sep 2, 2020

ijjk deleted the add/gsp-reloading branch September 2, 2020 16:57

This was referenced Sep 2, 2020

Update to show build indicator while re-fetching GS(S)P data in dev #16789

Merged

Show the build/activity indicator while re-fetching data for GS(S)P being edited #16790

Closed

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add automatic reloading when editing GS(S)P methods #16744

Add automatic reloading when editing GS(S)P methods #16744

ijjk commented Sep 1, 2020

ijjk commented Sep 1, 2020

ijjk commented Sep 1, 2020

Timer left a comment

ijjk commented Sep 2, 2020

ijjk commented Sep 2, 2020

Add automatic reloading when editing GS(S)P methods #16744

Add automatic reloading when editing GS(S)P methods #16744

Conversation

ijjk commented Sep 1, 2020

ijjk commented Sep 1, 2020

Stats from current PR

ijjk commented Sep 1, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Sep 2, 2020

Stats from current PR

ijjk commented Sep 2, 2020

Stats from current PR