Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use useRouter over Router for with-google-analytics example #16846

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Use useRouter over Router for with-google-analytics example #16846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955e6f3
Use useRouter over Router for with-google-analytics example
chibicode Sep 4, 2020
b6b1ed6
Merge branch 'canary' into hotfix-router-with-google-analytics
kodiakhq[bot] Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/with-google-analytics/pages/_app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
import { useEffect } from 'react'
import Router from 'next/router'
import { useRouter } from 'next/router'
import * as gtag from '../lib/gtag'

const App = ({ Component, pageProps }) => {
const router = useRouter()
useEffect(() => {
const handleRouteChange = (url) => {
gtag.pageview(url)
}
Router.events.on('routeChangeComplete', handleRouteChange)
router.events.on('routeChangeComplete', handleRouteChange)
return () => {
Router.events.off('routeChangeComplete', handleRouteChange)
router.events.off('routeChangeComplete', handleRouteChange)
}
}, [])
}, [router.events])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router.events was added with exhaustive-deps. I think this is fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes


return <Component {...pageProps} />
}
Expand Down