Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sass loader #16970

Merged
merged 4 commits into from
Sep 11, 2020
Merged

Upgrade sass loader #16970

merged 4 commits into from
Sep 11, 2020

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Sep 9, 2020 •
edited
Loading

The new version replaced big clone-deep package with dependency-free klona

Also deduped some related transitives.

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
timneutkens
timneutkens requested changes Sep 10, 2020
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this broke a lot of the CSS tests.

@TrySound TrySound changed the title Upgrade css and sass loaders Upgrade sass loader Sep 10, 2020
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@TrySound
Copy link
Contributor Author

@timneutkens Rebased css-loader upgrade. Now I see only typescript tests failed. Is this related to sass?

@ijjk
Copy link
Member

ijjk commented Sep 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 12.3s 13s ⚠️ +738ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.319 2.511 ⚠️ +0.19
/ avg req/sec 1077.82 995.52 ⚠️ -82.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.371 1.558 ⚠️ +0.19
/error-in-render avg req/sec 1823.19 1604.79 ⚠️ -218.4
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..6177.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ee619e3..fb8c.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-f1103fb..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 995 B 995 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 15.6s 15.5s -63ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..6177.js gzip 10.8 kB 10.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ee619e3..fb8c.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.5 kB 57.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-f1103fb..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 032f693

@merceyz
Copy link
Contributor

merceyz commented Sep 10, 2020

If merged this fixes #15753

@ijjk
Copy link
Member

ijjk commented Sep 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 13.9s 14s ⚠️ +168ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.538 2.515 -0.02
/ avg req/sec 984.94 993.88 +8.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.578 1.626 ⚠️ +0.05
/error-in-render avg req/sec 1583.91 1537.43 ⚠️ -46.48
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7ae8495..db56.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 15.4s 15.4s -53ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7ae8495..db56.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 5e80153

@ijjk
Copy link
Member

ijjk commented Sep 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 14.5s 14.5s -84ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Page Load Tests Overall increase ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.703 2.658 -0.04
/ avg req/sec 924.99 940.38 +15.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.675 1.564 -0.11
/error-in-render avg req/sec 1492.1 1598.85 +106.75
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7ae8495..db56.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
buildDuration 15.8s 16s ⚠️ +206ms
nodeModulesSize 57 MB 56.6 MB -421 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..68c9.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-7ae8495..db56.js gzip 7 kB 7 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.6 kB 57.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-5a735ed..dule.js gzip 6.07 kB 6.07 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.6 kB 52.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary TrySound/next.js upgrade-css-loaders Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 9821e14

@kodiakhq kodiakhq bot merged commit e5f9fbb into vercel:canary Sep 11, 2020
@timneutkens
Copy link
Member

Thanks!

@merceyz merceyz mentioned this pull request Sep 11, 2020
Closed
@TrySound TrySound deleted the upgrade-css-loaders branch September 11, 2020 13:02
@Timer Timer mentioned this pull request Sep 12, 2020
Closed
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@TrySound
Upgrade sass loader (vercel#16970)
fe3b225 
The new version replaced big clone-deep package with dependency-free klona
- https://github.com/webpack-contrib/sass-loader/releases/tag/v10.0.0
- https://github.com/webpack-contrib/sass-loader/releases/tag/v9.0.0

Also deduped some related transitives.
@OlehDutchenko OlehDutchenko mentioned this pull request Oct 8, 2020
Closed
@jamesmosier jamesmosier mentioned this pull request Oct 18, 2020
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrySound @ijjk @merceyz @timneutkens