Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error is passed up in minimal mode #22030

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 10, 2021

This ensures we pass the error up to the top-level when in minimal mode

@ijjk
Copy link
Member Author

ijjk commented Feb 10, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
buildDuration 11.2s 11.1s -95ms
nodeModulesSize 75.4 MB 75.4 MB ⚠️ +829 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
/ failed reqs 0 0
/ total time (seconds) 2.271 2.274 0
/ avg req/sec 1100.6 1099.34 ⚠️ -1.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.654 1.617 -0.04
/error-in-render avg req/sec 1511.06 1545.92 +34.86
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
buildDuration 13.1s 12.9s -225ms
nodeModulesSize 75.4 MB 75.4 MB ⚠️ +829 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
buildDuration 13.8s 14s ⚠️ +212ms
nodeModulesSize 75.4 MB 75.4 MB ⚠️ +829 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
/ failed reqs 0 0
/ total time (seconds) 2.286 2.344 ⚠️ +0.06
/ avg req/sec 1093.57 1066.44 ⚠️ -27.13
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.532 1.658 ⚠️ +0.13
/error-in-render avg req/sec 1631.92 1508.03 ⚠️ -123.89
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
597-6c246419..806f.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.9 kB 59.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-7a100..a392.js gzip 3.38 kB 3.38 kB
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js minimal-mode/error-pass Change
index.html gzip 584 B 584 B
link.html gzip 591 B 591 B
withRouter.html gzip 578 B 578 B
Overall change 1.75 kB 1.75 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "FKfzzvfgzQAkaRBfEMNCd",
+        "buildId": "N-oyxYH9LXh-Zs27WfVl1",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_buildManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_ssgManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "FKfzzvfgzQAkaRBfEMNCd",
+        "buildId": "N-oyxYH9LXh-Zs27WfVl1",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_buildManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_ssgManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "FKfzzvfgzQAkaRBfEMNCd",
+        "buildId": "N-oyxYH9LXh-Zs27WfVl1",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_buildManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FKfzzvfgzQAkaRBfEMNCd/_ssgManifest.js"
+      src="/_next/static/N-oyxYH9LXh-Zs27WfVl1/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c10a2d9

@ijjk ijjk marked this pull request as ready for review February 10, 2021 19:25
@kodiakhq kodiakhq bot merged commit 3f94f33 into vercel:canary Feb 11, 2021
@Timer Timer deleted the minimal-mode/error-pass branch February 11, 2021 14:36
This was referenced Jan 18, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants