Only create locale domain links if on locale domain #22032

ijjk · 2021-02-10T20:21:36Z

This updates to only create locale domain links if the current hostname is a locale domain to prevent making links unvisitable in development and preview environments where the configured locale domains don't point to the current build.

Closes: #21211
Closes: #22011

ijjk · 2021-02-10T20:43:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	10.6s	10.4s	-258ms
nodeModulesSize	75.4 MB	75.4 MB	⚠️ +1.81 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.154	2.113	-0.04
/ avg req/sec	1160.63	1182.88	+22.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.291	1.255	-0.04
/error-in-render avg req/sec	1936.43	1991.41	+54.98

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	⚠️ +18 B
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +18 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	⚠️ +5 B
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.1 kB	⚠️ +5 B

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Diffs

Diff for _buildManifest.js

@@ -7,7 +7,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-1de3df238a86bcb083d4.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3a08ad7c5282582ee217.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-439941a309010723a4e1.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-a5bdcfc87579b1d2776d.js"
   ],

Diff for link-3a08ad7..2582ee217.js

@@ -284,13 +284,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           (child.type === "a" && !("href" in child.props))
         ) {
           var curLocale =
-            typeof locale !== "undefined" ? locale : router && router.locale;
-          var localeDomain = (0, _router.getDomainLocale)(
-            as,
-            curLocale,
-            router && router.locales,
-            router && router.domainLocales
-          );
+            typeof locale !== "undefined" ? locale : router && router.locale; // we only render domain locales if we are currently on a domain locale
+          // so that locale links are still visitable in development/preview envs
+
+          var localeDomain =
+            router &&
+            router.isLocaleDomain &&
+            (0, _router.getDomainLocale)(
+              as,
+              curLocale,
+              router && router.locales,
+              router && router.domainLocales
+            );
           childProps.href =
             localeDomain ||
             (0, _router.addBasePath)(

Diff for 677f882d2ed8..abf803634.js

@@ -1589,6 +1589,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.defaultLocale = void 0;
           this.domainLocales = void 0;
           this.isReady = void 0;
+          this.isLocaleDomain = void 0;
           this._idx = 0;
 
           this.onPopState = function(e) {
@@ -1715,6 +1716,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             self.__NEXT_DATA__.gip ||
             (!autoExportDynamic && !self.location.search)
           );
+          this.isLocaleDomain = false;
 
           if (false) {
           }
@@ -4430,7 +4432,8 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         "locale",
         "locales",
         "defaultLocale",
-        "isReady"
+        "isReady",
+        "isLocaleDomain"
       ];
       var routerEvents = [
         "routeChangeStart",

Diff for index.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-3a08ad7c5282582ee217.js"
+      href="/_next/static/chunks/pages/link-439941a309010723a4e1.js"
       as="script"
     />
   </head>
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script
@@ -78,7 +78,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-3a08ad7c5282582ee217.js"
+      src="/_next/static/chunks/pages/link-439941a309010723a4e1.js"
       async=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>

Diff for withRouter.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	12.6s	12.7s	⚠️ +152ms
nodeModulesSize	75.4 MB	75.4 MB	⚠️ +1.81 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
677f882d2ed8..49c4.js gzip	13.1 kB	N/A	N/A
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
677f882d2ed8..4c01.js gzip	N/A	13.1 kB	N/A
Overall change	59.5 kB	59.5 kB	⚠️ +18 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	N/A	N/A
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
link-3b4cc9e..aaf5.js gzip	N/A	1.64 kB	N/A
Overall change	8.09 kB	8.1 kB	⚠️ +5 B

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_error.js	1 MB	1 MB	⚠️ +132 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1.01 MB	⚠️ +132 B
link.js	1.06 MB	1.06 MB	⚠️ +401 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +217 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +217 B
Overall change	5.19 MB	5.19 MB	⚠️ +1.1 kB

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	12.8s	12.5s	-323ms
nodeModulesSize	75.4 MB	75.4 MB	⚠️ +1.81 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.977	1.993	⚠️ +0.02
/ avg req/sec	1264.62	1254.69	⚠️ -9.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.291	1.26	-0.03
/error-in-render avg req/sec	1935.83	1983.74	+47.91

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
597-6c246419..806f.js gzip	13 kB	13.1 kB	⚠️ +16 B
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	⚠️ +16 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	⚠️ +5 B
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	⚠️ +5 B

Client Build Manifests

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
index.html gzip	584 B	586 B	⚠️ +2 B
link.html gzip	591 B	593 B	⚠️ +2 B
withRouter.html gzip	578 B	579 B	⚠️ +1 B
Overall change	1.75 kB	1.76 kB	⚠️ +5 B

Diffs

Diff for _buildManifest.js

@@ -7,7 +7,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-c71ae457cac4fc1870cd.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-7faf09bd68ceb178eba4.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3b4cc9eacc5ac90baaf5.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-f52980aaab8f3c73bf84.js"
   ],

Diff for link-7faf09b..eb178eba4.js

@@ -79,20 +79,20 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
           _ = e.locale;
         "string" === typeof v && (v = a.default.createElement("a", null, v));
         var b = a.Children.only(v),
-          w = b && "object" === typeof b && b.ref,
-          E = (0, i.useIntersection)({ rootMargin: "200px" }),
-          m = r(E, 2),
-          L = m[0],
-          M = m[1],
+          m = b && "object" === typeof b && b.ref,
+          w = (0, i.useIntersection)({ rootMargin: "200px" }),
+          E = r(w, 2),
+          L = E[0],
+          M = E[1],
           k = a.default.useCallback(
             function(e) {
               L(e),
-                w &&
-                  ("function" === typeof w
-                    ? w(e)
-                    : "object" === typeof w && (w.current = e));
+                m &&
+                  ("function" === typeof m
+                    ? m(e)
+                    : "object" === typeof m && (m.current = e));
             },
-            [w, L]
+            [m, L]
           );
         (0, a.useEffect)(
           function() {
@@ -145,12 +145,15 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         };
         if (e.passHref || ("a" === b.type && !("href" in b.props))) {
           var N = "undefined" !== typeof _ ? _ : t && t.locale,
-            O = (0, c.getDomainLocale)(
-              d,
-              N,
-              t && t.locales,
-              t && t.domainLocales
-            );
+            O =
+              t &&
+              t.isLocaleDomain &&
+              (0, c.getDomainLocale)(
+                d,
+                N,
+                t && t.locales,
+                t && t.domainLocales
+              );
           I.href =
             O ||
             (0, c.addBasePath)((0, c.addLocale)(d, N, t && t.defaultLocale));

Diff for 677f882d2ed8..dc0f149c4.js

@@ -882,7 +882,7 @@
           throw (e || (0, s.markAssetError)(t), t);
         });
       }
-      var M = (function() {
+      var D = (function() {
         function t(e, r, n, o) {
           var i = this,
             u = o.initialProps,
@@ -918,6 +918,7 @@
             (this.defaultLocale = void 0),
             (this.domainLocales = void 0),
             (this.isReady = void 0),
+            (this.isLocaleDomain = void 0),
             (this._idx = 0),
             (this.onPopState = function(t) {
               var e = t.state;
@@ -981,6 +982,7 @@
               !self.__NEXT_DATA__.gip &&
               (b || self.location.search)
             )),
+            (this.isLocaleDomain = !1),
             "//" !== n.substr(0, 2) &&
               this.changeState(
                 "replaceState",
@@ -1045,8 +1047,8 @@
                       C,
                       I,
                       A,
-                      M,
                       D,
+                      M,
                       N,
                       U,
                       W,
@@ -1137,7 +1139,7 @@
                                 (0, s.getClientBuildManifest)()
                               );
                             case 42:
-                              (M = e.sent), M.__rewrites, (e.next = 50);
+                              (D = e.sent), D.__rewrites, (e.next = 50);
                               break;
                             case 46:
                               return (
@@ -1155,7 +1157,7 @@
                                   ? (0, c.removePathTrailingSlash)(k(C))
                                   : C),
                                 this.urlIsNew(w) || f || (r = "replaceState"),
-                                (D = (0, c.removePathTrailingSlash)(C)),
+                                (M = (0, c.removePathTrailingSlash)(C)),
                                 (N = a),
                                 E(a))
                               ) {
@@ -1172,7 +1174,7 @@
                             case 62:
                               if (
                                 ((N = _(k(N), this.locale)),
-                                !(0, p.isDynamicRoute)(D))
+                                !(0, p.isDynamicRoute)(M))
                               ) {
                                 e.next = 78;
                                 break;
@@ -1180,9 +1182,9 @@
                               if (
                                 ((U = (0, d.parseRelativeUrl)(N)),
                                 (W = U.pathname),
-                                (F = (0, m.getRouteRegex)(D)),
+                                (F = (0, m.getRouteRegex)(M)),
                                 (q = (0, y.getRouteMatcher)(F)(W)),
-                                (B = (G = D === W) ? R(D, W, I) : {}),
+                                (B = (G = M === W) ? R(M, W, I) : {}),
                                 q && (!G || B.result))
                               ) {
                                 e.next = 77;
@@ -1216,7 +1218,7 @@
                                         W,
                                         ") is incompatible with the `href` value ("
                                       )
-                                      .concat(D, "). ")) +
+                                      .concat(M, "). ")) +
                                   "Read more: https://err.sh/vercel/next.js/".concat(
                                     G
                                       ? "href-interpolation-failed"
@@ -1240,7 +1242,7 @@
                                 t.events.emit("routeChangeStart", a, g),
                                 (e.prev = 79),
                                 (e.next = 82),
-                                this.getRouteInfo(D, C, I, a, N, g)
+                                this.getRouteInfo(M, C, I, a, N, g)
                               );
                             case 82:
                               if (
@@ -1313,10 +1315,10 @@
                               return (
                                 t.events.emit("beforeHistoryChange", a, g),
                                 this.changeState(r, o, a, i),
-                                (nt = i.shallow && this.route === D),
+                                (nt = i.shallow && this.route === M),
                                 (e.next = 114),
                                 this.set(
-                                  D,
+                                  M,
                                   C,
                                   I,
                                   w,
@@ -1896,7 +1898,7 @@
           t
         );
       })();
-      (e.default = M), (M.events = (0, f.default)());
+      (e.default = D), (D.events = (0, f.default)());
     },
     "g/15": function(t, e, r) {
       "use strict";
@@ -2653,7 +2655,8 @@
           "locale",
           "locales",
           "defaultLocale",
-          "isReady"
+          "isReady",
+          "isLocaleDomain"
         ],
         d = ["push", "replace", "reload", "back", "prefetch", "beforePopState"];
       function v() {

Diff for index.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "aLKC4ZrEdJXdCg_dvYhQC",
+        "buildId": "lkDOYUF8GAwy2g5oRQy8U",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_buildManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_ssgManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-7faf09bd68ceb178eba4.js"
+      href="/_next/static/chunks/pages/link-3b4cc9eacc5ac90baaf5.js"
       as="script"
     />
   </head>
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "aLKC4ZrEdJXdCg_dvYhQC",
+        "buildId": "lkDOYUF8GAwy2g5oRQy8U",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -78,15 +78,15 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-7faf09bd68ceb178eba4.js"
+      src="/_next/static/chunks/pages/link-3b4cc9eacc5ac90baaf5.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_buildManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_ssgManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "aLKC4ZrEdJXdCg_dvYhQC",
+        "buildId": "lkDOYUF8GAwy2g5oRQy8U",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_buildManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aLKC4ZrEdJXdCg_dvYhQC/_ssgManifest.js"
+      src="/_next/static/lkDOYUF8GAwy2g5oRQy8U/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: b24a893

javiercr · 2021-02-11T08:34:04Z

Wow, thank you for finding a fix that fast! 🙌

ijjk · 2021-02-11T10:07:38Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	11.3s	11.4s	⚠️ +77ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +1.81 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.244	2.354	⚠️ +0.11
/ avg req/sec	1113.97	1061.86	⚠️ -52.11
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.605	1.621	⚠️ +0.02
/error-in-render avg req/sec	1557.67	1542.56	⚠️ -15.11

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	⚠️ +18 B
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +18 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-f8ee040..45b1.js gzip	1.64 kB	1.64 kB	⚠️ +6 B
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.63 kB	8.64 kB	⚠️ +6 B

Client Build Manifests Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	347 B	348 B	⚠️ +1 B
Overall change	347 B	348 B	⚠️ +1 B

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
index.html gzip	614 B	615 B	⚠️ +1 B
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	609 B	⚠️ +1 B
Overall change	1.84 kB	1.84 kB	⚠️ +2 B

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-e732be88e7750c8b99f5.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-6c5bb8c23458fabe52bc.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-df11b317aadf9fd402f9.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-b3467c130a6d01a76dae.js"
   ],

Diff for link-6c5bb8c..8fabe52bc.js

@@ -284,13 +284,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           (child.type === "a" && !("href" in child.props))
         ) {
           var curLocale =
-            typeof locale !== "undefined" ? locale : router && router.locale;
-          var localeDomain = (0, _router.getDomainLocale)(
-            as,
-            curLocale,
-            router && router.locales,
-            router && router.domainLocales
-          );
+            typeof locale !== "undefined" ? locale : router && router.locale; // we only render domain locales if we are currently on a domain locale
+          // so that locale links are still visitable in development/preview envs
+
+          var localeDomain =
+            router &&
+            router.isLocaleDomain &&
+            (0, _router.getDomainLocale)(
+              as,
+              curLocale,
+              router && router.locales,
+              router && router.domainLocales
+            );
           childProps.href =
             localeDomain ||
             (0, _router.addBasePath)(

Diff for 677f882d2ed8..abf803634.js

@@ -1589,6 +1589,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           this.defaultLocale = void 0;
           this.domainLocales = void 0;
           this.isReady = void 0;
+          this.isLocaleDomain = void 0;
           this._idx = 0;
 
           this.onPopState = function(e) {
@@ -1715,6 +1716,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
             self.__NEXT_DATA__.gip ||
             (!autoExportDynamic && !self.location.search)
           );
+          this.isLocaleDomain = false;
 
           if (false) {
           }
@@ -4430,7 +4432,8 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         "locale",
         "locales",
         "defaultLocale",
-        "isReady"
+        "isReady",
+        "isLocaleDomain"
       ];
       var routerEvents = [
         "routeChangeStart",

Diff for index.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-6c5bb8c23458fabe52bc.js"
+      href="/_next/static/chunks/pages/link-df11b317aadf9fd402f9.js"
       as="script"
     />
   </head>
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script
@@ -78,7 +78,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-6c5bb8c23458fabe52bc.js"
+      src="/_next/static/chunks/pages/link-df11b317aadf9fd402f9.js"
       async=""
     ></script>
     <script src="/_next/static/BUILD_ID/_buildManifest.js" async=""></script>

Diff for withRouter.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4c703037e67abf803634.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0d8e916e638b246b9f81.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	13.1s	13.7s	⚠️ +585ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +1.81 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
677f882d2ed8..49c4.js gzip	13.1 kB	N/A	N/A
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
677f882d2ed8..4c01.js gzip	N/A	13.1 kB	N/A
Overall change	59.5 kB	59.5 kB	⚠️ +18 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-f8ee040..45b1.js gzip	1.64 kB	N/A	N/A
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
link-020eb27..d87f.js gzip	N/A	1.64 kB	N/A
Overall change	8.63 kB	8.64 kB	⚠️ +6 B

Client Build Manifests Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	347 B	348 B	⚠️ +1 B
Overall change	347 B	348 B	⚠️ +1 B

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_error.js	1 MB	1.01 MB	⚠️ +132 B
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	⚠️ +132 B
link.js	1.06 MB	1.06 MB	⚠️ +401 B
routerDirect.js	1.06 MB	1.06 MB	⚠️ +217 B
withRouter.js	1.06 MB	1.06 MB	⚠️ +217 B
Overall change	5.2 MB	5.2 MB	⚠️ +1.1 kB

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
buildDuration	13.5s	14s	⚠️ +439ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +1.81 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.313	2.29	-0.02
/ avg req/sec	1080.69	1091.84	+11.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.583	1.606	⚠️ +0.02
/error-in-render avg req/sec	1579.01	1556.45	⚠️ -22.56

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
597-6c246419..806f.js gzip	13 kB	13.1 kB	⚠️ +16 B
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	⚠️ +16 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-89095fe..14f1.js gzip	1.62 kB	1.63 kB	⚠️ +6 B
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.55 kB	8.56 kB	⚠️ +6 B

Client Build Manifests Overall decrease ✓

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
_buildManifest.js gzip	323 B	322 B	-1 B
Overall change	323 B	322 B	-1 B

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	ijjk/next.js i18n/client-locale-domains	Change
index.html gzip	586 B	585 B	-1 B
link.html gzip	592 B	592 B	✓
withRouter.html gzip	579 B	579 B	✓
Overall change	1.76 kB	1.76 kB	-1 B

Diffs

Diff for _buildManifest.js

@@ -8,7 +8,7 @@ self.__BUILD_MANIFEST = {
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-5023ef2ff38488073670.js"
   ],
-  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-f8ee040c07f6c23645b1.js"],
+  "/link": ["static\u002Fchunks\u002Fpages\u002Flink-020eb2794ab7d2ded87f.js"],
   "/routerDirect": [
     "static\u002Fchunks\u002Fpages\u002FrouterDirect-73e91dc4f2667a6a1a66.js"
   ],

Diff for link-f8ee040..6c23645b1.js

@@ -79,20 +79,20 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
           _ = e.locale;
         "string" === typeof v && (v = a.default.createElement("a", null, v));
         var b = a.Children.only(v),
-          w = b && "object" === typeof b && b.ref,
-          E = (0, i.useIntersection)({ rootMargin: "200px" }),
-          m = r(E, 2),
-          L = m[0],
-          M = m[1],
+          m = b && "object" === typeof b && b.ref,
+          w = (0, i.useIntersection)({ rootMargin: "200px" }),
+          E = r(w, 2),
+          L = E[0],
+          M = E[1],
           k = a.default.useCallback(
             function(e) {
               L(e),
-                w &&
-                  ("function" === typeof w
-                    ? w(e)
-                    : "object" === typeof w && (w.current = e));
+                m &&
+                  ("function" === typeof m
+                    ? m(e)
+                    : "object" === typeof m && (m.current = e));
             },
-            [w, L]
+            [m, L]
           );
         (0, a.useEffect)(
           function() {
@@ -145,12 +145,15 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         };
         if (e.passHref || ("a" === b.type && !("href" in b.props))) {
           var N = "undefined" !== typeof _ ? _ : t && t.locale,
-            O = (0, c.getDomainLocale)(
-              d,
-              N,
-              t && t.locales,
-              t && t.domainLocales
-            );
+            O =
+              t &&
+              t.isLocaleDomain &&
+              (0, c.getDomainLocale)(
+                d,
+                N,
+                t && t.locales,
+                t && t.domainLocales
+              );
           I.href =
             O ||
             (0, c.addBasePath)((0, c.addLocale)(d, N, t && t.defaultLocale));

Diff for 677f882d2ed8..dc0f149c4.js

@@ -882,7 +882,7 @@
           throw (e || (0, s.markAssetError)(t), t);
         });
       }
-      var M = (function() {
+      var D = (function() {
         function t(e, r, n, o) {
           var i = this,
             u = o.initialProps,
@@ -918,6 +918,7 @@
             (this.defaultLocale = void 0),
             (this.domainLocales = void 0),
             (this.isReady = void 0),
+            (this.isLocaleDomain = void 0),
             (this._idx = 0),
             (this.onPopState = function(t) {
               var e = t.state;
@@ -981,6 +982,7 @@
               !self.__NEXT_DATA__.gip &&
               (b || self.location.search)
             )),
+            (this.isLocaleDomain = !1),
             "//" !== n.substr(0, 2) &&
               this.changeState(
                 "replaceState",
@@ -1045,8 +1047,8 @@
                       C,
                       I,
                       A,
-                      M,
                       D,
+                      M,
                       N,
                       U,
                       W,
@@ -1137,7 +1139,7 @@
                                 (0, s.getClientBuildManifest)()
                               );
                             case 42:
-                              (M = e.sent), M.__rewrites, (e.next = 50);
+                              (D = e.sent), D.__rewrites, (e.next = 50);
                               break;
                             case 46:
                               return (
@@ -1155,7 +1157,7 @@
                                   ? (0, c.removePathTrailingSlash)(k(C))
                                   : C),
                                 this.urlIsNew(w) || f || (r = "replaceState"),
-                                (D = (0, c.removePathTrailingSlash)(C)),
+                                (M = (0, c.removePathTrailingSlash)(C)),
                                 (N = a),
                                 E(a))
                               ) {
@@ -1172,7 +1174,7 @@
                             case 62:
                               if (
                                 ((N = _(k(N), this.locale)),
-                                !(0, p.isDynamicRoute)(D))
+                                !(0, p.isDynamicRoute)(M))
                               ) {
                                 e.next = 78;
                                 break;
@@ -1180,9 +1182,9 @@
                               if (
                                 ((U = (0, d.parseRelativeUrl)(N)),
                                 (W = U.pathname),
-                                (F = (0, m.getRouteRegex)(D)),
+                                (F = (0, m.getRouteRegex)(M)),
                                 (q = (0, y.getRouteMatcher)(F)(W)),
-                                (B = (G = D === W) ? R(D, W, I) : {}),
+                                (B = (G = M === W) ? R(M, W, I) : {}),
                                 q && (!G || B.result))
                               ) {
                                 e.next = 77;
@@ -1216,7 +1218,7 @@
                                         W,
                                         ") is incompatible with the `href` value ("
                                       )
-                                      .concat(D, "). ")) +
+                                      .concat(M, "). ")) +
                                   "Read more: https://err.sh/vercel/next.js/".concat(
                                     G
                                       ? "href-interpolation-failed"
@@ -1240,7 +1242,7 @@
                                 t.events.emit("routeChangeStart", a, g),
                                 (e.prev = 79),
                                 (e.next = 82),
-                                this.getRouteInfo(D, C, I, a, N, g)
+                                this.getRouteInfo(M, C, I, a, N, g)
                               );
                             case 82:
                               if (
@@ -1313,10 +1315,10 @@
                               return (
                                 t.events.emit("beforeHistoryChange", a, g),
                                 this.changeState(r, o, a, i),
-                                (nt = i.shallow && this.route === D),
+                                (nt = i.shallow && this.route === M),
                                 (e.next = 114),
                                 this.set(
-                                  D,
+                                  M,
                                   C,
                                   I,
                                   w,
@@ -1896,7 +1898,7 @@
           t
         );
       })();
-      (e.default = M), (M.events = (0, f.default)());
+      (e.default = D), (D.events = (0, f.default)());
     },
     "g/15": function(t, e, r) {
       "use strict";
@@ -2653,7 +2655,8 @@
           "locale",
           "locales",
           "defaultLocale",
-          "isReady"
+          "isReady",
+          "isLocaleDomain"
         ],
         d = ["push", "replace", "reload", "back", "prefetch", "beforePopState"];
       function v() {

Diff for index.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "59sW05qCWR2p5Dh2L35Ok",
+        "buildId": "6HQam3Cf4wQ_o0ARliOQG",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_buildManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_ssgManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -32,7 +32,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/pages/link-f8ee040c07f6c23645b1.js"
+      href="/_next/static/chunks/pages/link-020eb2794ab7d2ded87f.js"
       as="script"
     />
   </head>
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "59sW05qCWR2p5Dh2L35Ok",
+        "buildId": "6HQam3Cf4wQ_o0ARliOQG",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -78,15 +78,15 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/pages/link-f8ee040c07f6c23645b1.js"
+      src="/_next/static/chunks/pages/link-020eb2794ab7d2ded87f.js"
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_buildManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_ssgManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "59sW05qCWR2p5Dh2L35Ok",
+        "buildId": "6HQam3Cf4wQ_o0ARliOQG",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4256237aee7dc0f149c4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3b6332a757fdf2824c01.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_buildManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/59sW05qCWR2p5Dh2L35Ok/_ssgManifest.js"
+      src="/_next/static/6HQam3Cf4wQ_o0ARliOQG/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 59779b5

Only create locale domain links if on locale domain

4d31f14

ijjk added the type: next label Feb 10, 2021

This comment has been minimized.

Sign in to view

add check before using router

b24a893

ijjk marked this pull request as ready for review February 10, 2021 23:20

ijjk requested review from lfades, Timer and timneutkens as code owners February 10, 2021 23:20

timneutkens approved these changes Feb 11, 2021

View reviewed changes

Merge branch 'canary' into i18n/client-locale-domains

59779b5

kodiakhq bot merged commit 55e4a3d into vercel:canary Feb 11, 2021

Timer deleted the i18n/client-locale-domains branch February 11, 2021 14:36

This was referenced Feb 16, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#288

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#289

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#290

Open

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only create locale domain links if on locale domain #22032

Only create locale domain links if on locale domain #22032

ijjk commented Feb 10, 2021 •

edited

Loading

This comment has been minimized.

ijjk commented Feb 10, 2021

Diffs

Diffs

javiercr commented Feb 11, 2021

ijjk commented Feb 11, 2021

Diffs

Diffs

Only create locale domain links if on locale domain #22032

Only create locale domain links if on locale domain #22032

Conversation

ijjk commented Feb 10, 2021 • edited Loading

This comment has been minimized.

ijjk commented Feb 10, 2021

Stats from current PR

Diffs

Diffs

javiercr commented Feb 11, 2021

ijjk commented Feb 11, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 10, 2021 •

edited

Loading