Upgrade to lerna 4 #22039

matamatanot · 2021-02-11T02:31:02Z

https://github.com/lerna/lerna/releases/tag/v4.0.0

Nothing was newly deprecated, nothing previously deprecated was removed. Migrating to v4 should be straightforward.

ijjk · 2021-02-11T02:41:34Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	10.5s	10.2s	-210ms
nodeModulesSize	75.4 MB	75.4 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.005	1.988	-0.02
/ avg req/sec	1247.1	1257.54	+10.44
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.244	1.212	-0.03
/error-in-render avg req/sec	2009.46	2063.51	+54.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	12.1s	12s	-44ms
nodeModulesSize	75.4 MB	75.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	12.7s	12.7s	-80ms
nodeModulesSize	75.4 MB	75.4 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.011	1.912	-0.1
/ avg req/sec	1243	1307.49	+64.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.371	1.192	-0.18
/error-in-render avg req/sec	1823.36	2098.02	+274.66

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
597-6c246419..806f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
index.html gzip	584 B	584 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	578 B	578 B	✓
Overall change	1.75 kB	1.75 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Kx18Kw93PQYR_wL1168-5",
+        "buildId": "cQRDLliYX_z7jdJJ4u0xI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_buildManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_ssgManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Kx18Kw93PQYR_wL1168-5",
+        "buildId": "cQRDLliYX_z7jdJJ4u0xI",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_buildManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_ssgManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Kx18Kw93PQYR_wL1168-5",
+        "buildId": "cQRDLliYX_z7jdJJ4u0xI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_buildManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Kx18Kw93PQYR_wL1168-5/_ssgManifest.js"
+      src="/_next/static/cQRDLliYX_z7jdJJ4u0xI/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 304c736

timneutkens

Looks fine 👍

…hore/update-lerna

ijjk · 2021-02-12T12:14:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	11.4s	10.9s	-423ms
nodeModulesSize	69.8 MB	69.8 MB	-5.22 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.992	2.041	⚠️ +0.05
/ avg req/sec	1254.71	1225.13	⚠️ -29.58
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.251	1.289	⚠️ +0.04
/error-in-render avg req/sec	1998.37	1939.6	⚠️ -58.77

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	13.2s	13.6s	⚠️ +323ms
nodeModulesSize	69.8 MB	69.8 MB	-5.22 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
buildDuration	13.5s	13.2s	-276ms
nodeModulesSize	69.8 MB	69.8 MB	-5.22 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.997	2.08	⚠️ +0.08
/ avg req/sec	1251.57	1201.72	⚠️ -49.85
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.217	1.335	⚠️ +0.12
/error-in-render avg req/sec	2054.31	1872.46	⚠️ -181.85

Client Bundles (main, webpack, commons)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
597-d08f5fe5..d690.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-7cc9e62..ef27.js gzip	1.66 kB	1.66 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.59 kB	8.59 kB	✓

Client Build Manifests

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	matamatanot/next.js chore/update-lerna	Change
index.html gzip	584 B	584 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	579 B	579 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "AVDYT5RzJq4dJx4Rhp_u9",
+        "buildId": "jU8AmePOugpKktuTEvtQe",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_buildManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_ssgManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "AVDYT5RzJq4dJx4Rhp_u9",
+        "buildId": "jU8AmePOugpKktuTEvtQe",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_buildManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_ssgManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "AVDYT5RzJq4dJx4Rhp_u9",
+        "buildId": "jU8AmePOugpKktuTEvtQe",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_buildManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AVDYT5RzJq4dJx4Rhp_u9/_ssgManifest.js"
+      src="/_next/static/jU8AmePOugpKktuTEvtQe/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: d9f032d

chore: update lerna

304c736

matamatanot requested review from ijjk, lfades, Timer and timneutkens as code owners February 11, 2021 02:31

timneutkens previously approved these changes Feb 11, 2021

View reviewed changes

timneutkens added 2 commits February 12, 2021 12:55

Update pre-compiled

7f0a4ce

Merge branch 'canary' of github.com:vercel/next.js into matamatanot-c…

d9f032d

…hore/update-lerna

timneutkens dismissed their stale review via d9f032d February 12, 2021 12:03

ijjk added the type: next label Feb 12, 2021

timneutkens approved these changes Feb 12, 2021

View reviewed changes

timneutkens merged commit b3aa1d1 into vercel:canary Feb 12, 2021

This was referenced Feb 16, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#288

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#289

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.7 blubfoo/next.js#290

Open

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to lerna 4 #22039

Upgrade to lerna 4 #22039

matamatanot commented Feb 11, 2021

ijjk commented Feb 11, 2021

Diffs

timneutkens left a comment

ijjk commented Feb 12, 2021

Diffs

Upgrade to lerna 4 #22039

Upgrade to lerna 4 #22039

Conversation

matamatanot commented Feb 11, 2021

ijjk commented Feb 11, 2021

Stats from current PR

Diffs

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Feb 12, 2021

Stats from current PR

Diffs