Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if parentspan is provided in profiler #22061

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

timneutkens
Copy link
Member

Fixes the issue that webpack-compile ended up as a separate trace because parent was undefined

Fixes the issue that webpack-compile ended up as a separate trace because `parent` was undefined
@ijjk
Copy link
Member

ijjk commented Feb 11, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
buildDuration 11.9s 11.7s -247ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +323 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
/ failed reqs 0 0
/ total time (seconds) 2.32 2.192 -0.13
/ avg req/sec 1077.55 1140.43 +62.88
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.627 1.541 -0.09
/error-in-render avg req/sec 1536.49 1622.3 +85.81
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
677f882d2ed8..4c01.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
amp-e3e9bc99..932c.js gzip 536 B 536 B
hooks-5023ef..3670.js gzip 888 B 888 B
index-3a2b03..c677.js gzip 227 B 227 B
link-020eb27..d87f.js gzip 1.64 kB 1.64 kB
routerDirect..1a66.js gzip 303 B 303 B
withRouter-9..1b7d.js gzip 302 B 302 B
Overall change 8.64 kB 8.64 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_buildManifest.js gzip 348 B 348 B
Overall change 348 B 348 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
index.html gzip 615 B 615 B
link.html gzip 620 B 620 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
buildDuration 14s 14.3s ⚠️ +234ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +323 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
677f882d2ed8..4c01.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.5 kB 59.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
amp-e3e9bc99..932c.js gzip 536 B 536 B
hooks-5023ef..3670.js gzip 888 B 888 B
index-3a2b03..c677.js gzip 227 B 227 B
link-020eb27..d87f.js gzip 1.64 kB 1.64 kB
routerDirect..1a66.js gzip 303 B 303 B
withRouter-9..1b7d.js gzip 302 B 302 B
Overall change 8.64 kB 8.64 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_buildManifest.js gzip 348 B 348 B
Overall change 348 B 348 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_error.js 1.01 MB 1.01 MB
404.html 2.67 kB 2.67 kB
amp.amp.html 10.4 kB 10.4 kB
amp.html 1.86 kB 1.86 kB
hooks.html 1.92 kB 1.92 kB
index.js 1.01 MB 1.01 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.06 MB 1.06 MB
withRouter.js 1.06 MB 1.06 MB
Overall change 5.2 MB 5.2 MB

Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
buildDuration 14.6s 14.5s -99ms
nodeModulesSize 69.8 MB 69.8 MB ⚠️ +323 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
/ failed reqs 0 0
/ total time (seconds) 2.32 2.194 -0.13
/ avg req/sec 1077.46 1139.42 +61.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.603 1.592 -0.01
/error-in-render avg req/sec 1559.44 1570.29 +10.85
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
597-913d7a8f..1f0e.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.9 kB 59.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-9e190..f9d6.js gzip 3.38 kB 3.38 kB
amp-7fd79cc4..99ee.js gzip 538 B 538 B
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-b960f55..1c2e.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.56 kB 8.56 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
_buildManifest.js gzip 322 B 322 B
Overall change 322 B 322 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/parentspan-profiling Change
index.html gzip 585 B 585 B
link.html gzip 592 B 592 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "dRl5CdbQWp2FDp4AhSz-3",
+        "buildId": "fWS-zLMJSdrfzTDxoT9vV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_buildManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_ssgManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "dRl5CdbQWp2FDp4AhSz-3",
+        "buildId": "fWS-zLMJSdrfzTDxoT9vV",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_buildManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_ssgManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "dRl5CdbQWp2FDp4AhSz-3",
+        "buildId": "fWS-zLMJSdrfzTDxoT9vV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_buildManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/dRl5CdbQWp2FDp4AhSz-3/_ssgManifest.js"
+      src="/_next/static/fWS-zLMJSdrfzTDxoT9vV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c735abe

@timneutkens timneutkens merged commit 83657b6 into vercel:canary Feb 12, 2021
@timneutkens timneutkens deleted the fix/parentspan-profiling branch February 12, 2021 10:17
This was referenced Jan 18, 2022
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants