Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @hapi/accept to latest #24283

Merged
merged 6 commits into from
May 16, 2021
Merged

Update @hapi/accept to latest #24283

merged 6 commits into from
May 16, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 20, 2021 •
edited by timneutkens
Loading

Updates to the latest version of @hapi/accept, opening this one instead of #23142 since it has unrelated changes and is stale.

Close: #23142
Fixes #20488

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk marked this pull request as ready for review April 20, 2021 20:00
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@Lunnatica Lunnatica mentioned this pull request May 16, 2021
Closed
@timneutkens timneutkens mentioned this pull request May 16, 2021
Closed
@ijjk
Copy link
Member Author

ijjk commented May 16, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/accept Change
buildDuration 14.3s 14.5s ⚠️ +222ms
buildDurationCached 4.3s 4.3s ⚠️ +5ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +140 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/accept Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.421 2.424 0
/ avg req/sec 1032.5 1031.38 ⚠️ -1.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.255 1.233 -0.02
/error-in-render avg req/sec 1991.95 2027.2 +35.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/accept Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/accept Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/accept Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/accept Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/accept Change
index.html gzip 560 B 560 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/accept Change
buildDuration 17.8s 18.2s ⚠️ +382ms
buildDurationCached 6.5s 6.5s ⚠️ +11ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +140 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/accept Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.4 kB 19.4 kB ✓
webpack-HASH.js gzip 994 B 994 B ✓
Overall change 59.7 kB 59.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/accept Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/accept Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.54 kB 8.54 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/accept Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/accept Change
_error.js 1.34 MB 1.34 MB ⚠️ +108 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ⚠️ +110 B
link.js 1.4 MB 1.4 MB ⚠️ +108 B
routerDirect.js 1.4 MB 1.4 MB ⚠️ +108 B
withRouter.js 1.4 MB 1.4 MB ⚠️ +108 B
Overall change 6.91 MB 6.91 MB ⚠️ +542 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/accept Change
buildDuration 12.4s 12.6s ⚠️ +169ms
buildDurationCached 5.2s 5.2s ⚠️ +37ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +140 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/accept Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.484 2.43 -0.05
/ avg req/sec 1006.43 1028.69 +22.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.255 1.278 ⚠️ +0.02
/error-in-render avg req/sec 1991.64 1955.5 ⚠️ -36.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/accept Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.26 kB 7.26 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/accept Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/accept Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.74 kB 3.74 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.38 kB 9.38 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/accept Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/accept Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: bc5465b

@kodiakhq kodiakhq bot merged commit a442053 into vercel:canary May 16, 2021
@ijjk ijjk deleted the update/accept branch May 16, 2021 23:29
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@ijjk
Update @hapi/accept to latest (vercel#24283)
4f44954 
Updates to the latest version of `@hapi/accept`, opening this one instead of vercel#23142 since it has unrelated changes and is stale. 

Close: vercel#23142
Fixes vercel#20488
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple issues related to ii18n (redirects, localeDetection)
2 participants
@ijjk @timneutkens