feat(build): Log whether type checking is actually performed #24440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
eps1lon
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as code owners
|
CI failures look unrelated to me. |
This comment has been minimized.
This comment has been minimized.
eps1lon
force-pushed
the
feat/build-log-ignore-ts-errors-flag
branch
from
a6119c2
to
e25b696
Compare
This comment has been minimized.
This comment has been minimized.
timneutkens
previously approved these changes
May 7, 2021
|
Looks fine to land, seems there's a merge conflict though 👀 |
Looking at it right now. Should telemetry still send an event when type-checking is disabled? Or should we include whether type-checking is enabled? |
…nore-ts-errors-flag
This comment has been minimized.
This comment has been minimized.
|
Yeah telemetry can be skipped for that case 👍 |
This comment has been minimized.
This comment has been minimized.
timneutkens
approved these changes
May 7, 2021
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| buildDuration | 15.9s | 16.1s | |
| buildDurationCached | 5.3s | 4.8s | -463ms |
| nodeModulesSize | 46.6 MB | 46.6 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.763 | 2.775 | |
| / avg req/sec | 904.76 | 901.02 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.695 | 1.647 | -0.05 |
| /error-in-render avg req/sec | 1474.51 | 1517.55 | +43.04 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.3 kB | 19.3 kB | ✓ |
| webpack-HASH.js gzip | 996 B | 996 B | ✓ |
| Overall change | 59.6 kB | 59.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.05 kB | 3.05 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| 99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.52 kB | 8.52 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 394 B | 394 B | ✓ |
| Overall change | 394 B | 394 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| index.html gzip | 560 B | 560 B | ✓ |
| link.html gzip | 569 B | 569 B | ✓ |
| withRouter.html gzip | 557 B | 557 B | ✓ |
| Overall change | 1.69 kB | 1.69 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| buildDuration | 19.6s | 19.4s | -244ms |
| buildDurationCached | 7.3s | 7.2s | -121ms |
| nodeModulesSize | 46.6 MB | 46.6 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
| main-HASH.js gzip | 19.3 kB | 19.3 kB | ✓ |
| webpack-HASH.js gzip | 996 B | 996 B | ✓ |
| Overall change | 59.6 kB | 59.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
| Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.02 kB | 1.02 kB | ✓ |
| _error-HASH.js gzip | 3.05 kB | 3.05 kB | ✓ |
| amp-HASH.js gzip | 526 B | 526 B | ✓ |
| css-HASH.js gzip | 334 B | 334 B | ✓ |
| hooks-HASH.js gzip | 890 B | 890 B | ✓ |
| index-HASH.js gzip | 262 B | 262 B | ✓ |
| link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
| routerDirect..HASH.js gzip | 331 B | 331 B | ✓ |
| withRouter-HASH.js gzip | 329 B | 329 B | ✓ |
| 99a142a5cfae..804.css gzip | 125 B | 125 B | ✓ |
| Overall change | 8.52 kB | 8.52 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 394 B | 394 B | ✓ |
| Overall change | 394 B | 394 B | ✓ |
Serverless bundles
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _error.js | 1.34 MB | 1.34 MB | ✓ |
| 404.html | 2.42 kB | 2.42 kB | ✓ |
| 500.html | 2.41 kB | 2.41 kB | ✓ |
| amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
| amp.html | 1.61 kB | 1.61 kB | ✓ |
| css.html | 1.79 kB | 1.79 kB | ✓ |
| hooks.html | 1.67 kB | 1.67 kB | ✓ |
| index.js | 1.35 MB | 1.35 MB | ✓ |
| link.js | 1.4 MB | 1.4 MB | ✓ |
| routerDirect.js | 1.39 MB | 1.39 MB | ✓ |
| withRouter.js | 1.39 MB | 1.39 MB | ✓ |
| Overall change | 6.9 MB | 6.9 MB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| buildDuration | 13.3s | 13.5s | |
| buildDurationCached | 5.7s | 5.5s | -206ms |
| nodeModulesSize | 46.6 MB | 46.6 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.855 | 2.797 | -0.06 |
| / avg req/sec | 875.72 | 893.85 | +18.13 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.726 | 1.587 | -0.14 |
| /error-in-render avg req/sec | 1448.59 | 1575.76 | +127.17 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| 677f882d2ed8..HASH.js gzip | 13.3 kB | 13.3 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-HASH.js gzip | 7.19 kB | 7.19 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| Overall change | 60.2 kB | 60.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
| Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-HASH.js gzip | 3.72 kB | 3.72 kB | ✓ |
| amp-HASH.js gzip | 536 B | 536 B | ✓ |
| css-HASH.js gzip | 339 B | 339 B | ✓ |
| hooks-HASH.js gzip | 887 B | 887 B | ✓ |
| index-HASH.js gzip | 227 B | 227 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
| withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
| 21c68fa65a48..217.css gzip | 125 B | 125 B | ✓ |
| Overall change | 9.37 kB | 9.37 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 420 B | 420 B | ✓ |
| Overall change | 420 B | 420 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | eps1lon/next.js feat/build-log-ignore-ts-errors-flag | Change | |
|---|---|---|---|
| index.html gzip | 613 B | 613 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 606 B | 606 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
|
Thanks! |
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 1, 2021
…24440) Closes vercel#24889 ## Feature Currently `next build` is logging "Checking validity of types" even if `typescript.ignoreBuildErrors` is `true`. It seems like these options still work so `next build` either shouldn't log anything related to type-checking or log that type-checking is skipped. I decided to branch the log message for clarity. Happy to add a test but I'm not sure if you have existing infra considering https://github.com/vercel/next.js/pull/23226/files (which added the message) didn't add or change tests either. CI failures look unrelated to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24889
Feature
Currently
next buildis logging "Checking validity of types" even iftypescript.ignoreBuildErrorsistrue. It seems like these options still work sonext buildeither shouldn't log anything related to type-checking or log that type-checking is skipped.I decided to branch the log message for clarity.
Happy to add a test but I'm not sure if you have existing infra considering https://github.com/vercel/next.js/pull/23226/files (which added the message) didn't add or change tests either.
CI failures look unrelated to me.