Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CNA install succeeds with npm and example flags #25267

Merged
merged 5 commits into from
May 19, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 19, 2021

This removes the logLevel error flag from the npm install with create-next-app since npm doesn't honor this flag and treats it as if we're only installing an error package causing the install with a provided package.json from an example to fail. This also updates our tests to ensure the install succeeded correctly. Thanks to @creationix for helping investigate!

Bug

  • Related issues linked using fixes #number
  • Integration tests added

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label May 19, 2021
Copy link

@creationix creationix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented May 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
buildDuration 11.2s 11.4s ⚠️ +136ms
buildDurationCached 3.4s 3.4s -13ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
/ failed reqs 0 0
/ total time (seconds) 2.075 2.074 0
/ avg req/sec 1204.57 1205.36 +0.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.068 1.107 ⚠️ +0.04
/error-in-render avg req/sec 2339.88 2258.33 ⚠️ -81.55
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
index.html gzip 559 B 559 B
link.html gzip 569 B 569 B
withRouter.html gzip 556 B 556 B
Overall change 1.68 kB 1.68 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
buildDuration 13.2s 14s ⚠️ +813ms
buildDurationCached 4.4s 4.5s ⚠️ +95ms
nodeModulesSize 46.7 MB 46.7 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
framework-HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 19.4 kB 19.4 kB
webpack-HASH.js gzip 994 B 994 B
Overall change 59.7 kB 59.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_app-HASH.js gzip 1.02 kB 1.02 kB
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 526 B 526 B
css-HASH.js gzip 334 B 334 B
hooks-HASH.js gzip 890 B 890 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 1.65 kB 1.65 kB
routerDirect..HASH.js gzip 331 B 331 B
withRouter-HASH.js gzip 329 B 329 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 8.54 kB 8.54 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_buildManifest.js gzip 390 B 390 B
Overall change 390 B 390 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_error.js 16.9 kB 16.9 kB
404.html 2.42 kB 2.42 kB
500.html 2.41 kB 2.41 kB
amp.amp.html 10.8 kB 10.8 kB
amp.html 1.61 kB 1.61 kB
css.html 1.79 kB 1.79 kB
hooks.html 1.67 kB 1.67 kB
index.js 17.2 kB 17.2 kB
link.js 17.4 kB 17.4 kB ⚠️ +2 B
routerDirect.js 17.4 kB 17.4 kB
withRouter.js 17.4 kB 17.4 kB
Overall change 107 kB 107 kB ⚠️ +2 B

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
buildDuration 10.8s 11.4s ⚠️ +595ms
buildDurationCached 5s 4.8s -229ms
nodeModulesSize 46.7 MB 46.7 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
/ failed reqs 0 0
/ total time (seconds) 2.223 2.167 -0.06
/ avg req/sec 1124.54 1153.52 +28.98
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.129 1.101 -0.03
/error-in-render avg req/sec 2213.91 2270.98 +57.07
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 7.25 kB 7.25 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 60.3 kB 60.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_app-HASH.js gzip 1.28 kB 1.28 kB
_error-HASH.js gzip 3.74 kB 3.74 kB
amp-HASH.js gzip 536 B 536 B
css-HASH.js gzip 339 B 339 B
hooks-HASH.js gzip 887 B 887 B
index-HASH.js gzip 227 B 227 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 303 B 303 B
withRouter-HASH.js gzip 302 B 302 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 9.38 kB 9.38 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
_buildManifest.js gzip 420 B 420 B
Overall change 420 B 420 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js bugfix/cna-npm-example Change
index.html gzip 614 B 614 B
link.html gzip 621 B 621 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB
Commit: 7bfe030

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants