Improve check for eslint version #25910

timneutkens · 2021-06-08T20:26:47Z

Ensures eslint can be resolved up the directory tree.

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

ijjk · 2021-06-08T21:10:39Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
buildDuration	12.5s	12.8s	⚠️ +232ms
buildDurationCached	3.1s	3.1s	✓
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +338 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.463	2.518	⚠️ +0.05
/ avg req/sec	1014.85	992.72	⚠️ -22.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.277	1.308	⚠️ +0.03
/error-in-render avg req/sec	1957.52	1911.04	⚠️ -46.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
index.html gzip	573 B	573 B	✓
link.html gzip	580 B	580 B	✓
withRouter.html gzip	567 B	567 B	✓
Overall change	1.72 kB	1.72 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
buildDuration	14.5s	14.7s	⚠️ +218ms
buildDurationCached	4.3s	4.2s	-57ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +338 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.07 kB	3.07 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	334 B	334 B	✓
hooks-HASH.js gzip	890 B	890 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	333 B	333 B	✓
withRouter-HASH.js gzip	330 B	330 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_buildManifest.js gzip	392 B	392 B	✓
Overall change	392 B	392 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_error.js	16.9 kB	16.9 kB	⚠️ +2 B
404.html	2.44 kB	2.44 kB	✓
500.html	2.43 kB	2.43 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.63 kB	1.63 kB	✓
css.html	1.81 kB	1.81 kB	✓
hooks.html	1.69 kB	1.69 kB	✓
index.js	17.2 kB	17.2 kB	✓
link.js	17.4 kB	17.4 kB	⚠️ +2 B
routerDirect.js	17.4 kB	17.4 kB	✓
withRouter.js	17.4 kB	17.4 kB	✓
Overall change	107 kB	107 kB	⚠️ +4 B

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
buildDuration	11.3s	11.5s	⚠️ +162ms
buildDurationCached	4.6s	4.6s	-5ms
nodeModulesSize	46.5 MB	46.5 MB	⚠️ +338 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.582	2.577	0
/ avg req/sec	968.07	970.22	+2.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.296	1.29	-0.01
/error-in-render avg req/sec	1928.67	1937.82	+9.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	61.1 kB	61.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.63 kB	1.63 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.17 kB	9.17 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/resolving-eslint	Change
index.html gzip	625 B	625 B	✓
link.html gzip	632 B	632 B	✓
withRouter.html gzip	620 B	620 B	✓
Overall change	1.88 kB	1.88 kB	✓

Commit: 22aeede

ijjk · 2021-06-08T21:24:19Z

Failing test suites

Commit: 22aeede

test/integration/basic/test/index.test.js

Basic Features > should polyfill Node.js modules

Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

Co-authored-by: JJ Kasper <jj@jjsweb.site>

Improve check for eslint version

c6fdb9f

timneutkens requested review from divmain, ijjk, lfades and shuding as code owners June 8, 2021 20:26

ijjk added the type: next label Jun 8, 2021

This comment has been minimized.

Sign in to view

ijjk approved these changes Jun 8, 2021

View reviewed changes

Merge branch 'canary' into fix/resolving-eslint

22aeede

ijjk merged commit c862409 into vercel:canary Jun 8, 2021

sync-by-unito bot mentioned this pull request Jun 16, 2021

chore(deps): bump next from 10.1.2 to 11.0.0 filecoin-project/slate#793

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Improve check for eslint version (vercel#25910)

e8e22fd

Co-authored-by: JJ Kasper <jj@jjsweb.site>

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve check for eslint version #25910

Improve check for eslint version #25910

timneutkens commented Jun 8, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 8, 2021

ijjk commented Jun 8, 2021

Improve check for eslint version #25910

Improve check for eslint version #25910

Conversation

timneutkens commented Jun 8, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 8, 2021

Stats from current PR

ijjk commented Jun 8, 2021

Failing test suites