(examples/with-i18n-next-intl): fixes warning #25928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
|
@akellbl4 Can you also add the StackBlitz button to the ## Preview
Preview the example live on [StackBlitz](http://stackblitz.com/):
[](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-i18n-next-intl)I have tested it on your fork. |
|
@d3lm as I can see this example already has the StackBlitz button. |
|
Ohhh, good catch. Then forget what I said! 😂 |
akellbl4
changed the title
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
### Documentation / Examples Fixed one of the items from vercel#25854 - Fixes warning from `next-intl` - Hides locale selector in case if no other location - Fixes path `next/router` import - Removes unused variable --- - [x] Add the StackBlitz button in README.md - [x] Make sure the linting passes [Live demo on StackBlitz](https://stackblitz.com/github/akellbl4/next.js/tree/fix/example-with-i18n-next-intl-missing-other/examples/with-i18n-next-intl)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
Fixed one of the items from #25854
next-intlnext/routerimportLive demo on StackBlitz