Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set Prettier to ignore integration output HTMLs #26353

Merged
merged 2 commits into from
Jul 20, 2021
Merged

chore: Set Prettier to ignore integration output HTMLs #26353

merged 2 commits into from
Jul 20, 2021

Conversation

petermekhaeil
Copy link
Contributor

Prettier is failing because it is checking the output of the integration tests.

This commit will set Prettier to ignore those HTMLs.

Documentation / Examples

  • Make sure the linting passes

.prettierignore Outdated
@@ -16,3 +16,5 @@ packages/next-codemod/**/*.js
packages/next-codemod/**/*.d.ts
packages/next-env/**/*.d.ts
test-timings.json
test/integration/custom-routes/out/**/*.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a negative lookahead would be better here, test only holds .js,.jsx,.ts, and .tsx so it'd be useful to only match for those.

@ijjk ijjk requested review from huozhi, padmaia and styfle as code owners July 20, 2021 19:27
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches our **/.next/** ignore so looks good to me, thanks!

@ijjk
Copy link
Member

ijjk commented Jul 20, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
buildDuration 13.4s 13.6s ⚠️ +195ms
buildDurationCached 3.1s 3.1s -9ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
/ failed reqs 0 0
/ total time (seconds) 2.164 2.194 ⚠️ +0.03
/ avg req/sec 1155.36 1139.3 ⚠️ -16.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.202 1.202
/error-in-render avg req/sec 2079.45 2079.52 +0.07
Client Bundles (main, webpack, commons)
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.61 kB 5.61 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
buildDuration 10.9s 10.8s -33ms
buildDurationCached 4.2s 4.2s ⚠️ +36ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
/ failed reqs 0 0
/ total time (seconds) 2.241 2.24 0
/ avg req/sec 1115.57 1116.21 +0.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.199 1.206 ⚠️ +0.01
/error-in-render avg req/sec 2084.24 2072.77 ⚠️ -11.47
Client Bundles (main, webpack, commons)
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.4 kB 68.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary petermekhaeil/next.js prettier-ignore-test-htmls Change
index.html gzip 577 B 577 B
link.html gzip 587 B 587 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 8164c88

@ijjk

This comment has been minimized.

@ijjk ijjk merged commit caaa1be into vercel:canary Jul 20, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants