Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove period for ESLint passHref docs link. #26402

Merged
merged 3 commits into from
Jun 20, 2021
Merged

Remove period for ESLint passHref docs link. #26402

merged 3 commits into from
Jun 20, 2021

Conversation

leerob
Copy link
Member

@leerob leerob commented Jun 20, 2021

Due to the period at the end of this sentence, when clicking on the link it would 404. This PR simply removes the period from the message.

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jun 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js passhref-404-docs Change
buildDuration 13.5s 13.6s ⚠️ +153ms
buildDurationCached 3.3s 3.3s ⚠️ +20ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js passhref-404-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.425 2.455 ⚠️ +0.03
/ avg req/sec 1031.13 1018.28 ⚠️ -12.85
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.33 1.374 ⚠️ +0.04
/error-in-render avg req/sec 1880.15 1819.69 ⚠️ -60.46
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js passhref-404-docs Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js passhref-404-docs Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js passhref-404-docs Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js passhref-404-docs Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js passhref-404-docs Change
index.html gzip 523 B 523 B ✓
link.html gzip 532 B 532 B ✓
withRouter.html gzip 514 B 514 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js passhref-404-docs Change
buildDuration 15.4s 15.4s ⚠️ +48ms
buildDurationCached 4.5s 4.6s ⚠️ +35ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js passhref-404-docs Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js passhref-404-docs Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js passhref-404-docs Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js passhref-404-docs Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js passhref-404-docs Change
_error.js 16.9 kB 16.9 kB ✓
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ✓
link.js 17.5 kB 17.5 kB -2 B
routerDirect.js 17.3 kB 17.3 kB ✓
withRouter.js 17.3 kB 17.3 kB ✓
Overall change 105 kB 105 kB -2 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js passhref-404-docs Change
buildDuration 12.2s 12.1s -124ms
buildDurationCached 4.9s 4.7s -177ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js passhref-404-docs Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.433 2.45 ⚠️ +0.02
/ avg req/sec 1027.63 1020.57 ⚠️ -7.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.353 1.359 ⚠️ +0.01
/error-in-render avg req/sec 1847.39 1839.72 ⚠️ -7.67
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js passhref-404-docs Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 757 B 757 B ✓
Overall change 63.8 kB 63.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js passhref-404-docs Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js passhref-404-docs Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js passhref-404-docs Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js passhref-404-docs Change
index.html gzip 568 B 568 B ✓
link.html gzip 581 B 581 B ✓
withRouter.html gzip 561 B 561 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 0121204

@kodiakhq kodiakhq bot merged commit ad5e9bd into canary Jun 20, 2021
@kodiakhq kodiakhq bot deleted the passhref-404-docs branch June 20, 2021 22:55
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@leerob
Remove period for ESLint passHref docs link. (vercel#26402)
bf949b3 
Due to the period at the end of this sentence, when clicking on the link it would 404. This PR simply removes the period from the message.
bordeo pushed a commit to bordeo/next.js that referenced this pull request Jul 12, 2021
Merge tag 'v11.0.1' into feat/add-pagesPaths-config-options
8f0bca2 
v11.0.1

* tag 'v11.0.1': (374 commits)
  v11.0.1
  v11.0.1-canary.8
  Ensure image-types file is included (vercel#26495)
  Strongly type `Router.events.on` and `Router.events.off` (vercel#26456)
  v11.0.1-canary.7
  Update i18n fields in docs (vercel#26492)
  Update to only add image import types when enabled (vercel#26485)
  Fix domain locales not available on client (vercel#26083)
  chore: Add Alex to lint documentation (vercel#26354)
  fix: ignore invalid accept-language header (vercel#26476)
  Add module.exports to security headers documentation (vercel#26466)
  (examples/with-webassembly) fixed for webpack 5 (vercel#26440)
  Add check for startLatency in fast refresh (vercel#26417)
  v11.0.1-canary.6
  docs(router.md) Add note about page state and navigation (vercel#26320)
  Remove period for ESLint `passHref` docs link. (vercel#26402)
  Update with-eslint example. (vercel#25817)
  Docs: Add Prettier section on ESLint page (vercel#26347)
  add missing closing bracket (vercel#26375)
  Improve the `next/script` documentation. (vercel#26325)
  ...
@snyk-bot snyk-bot mentioned this pull request Jul 30, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcsdevv mcsdevv mcsdevv approved these changes

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leerob @ijjk @mcsdevv