More React 17 clean up #26775

devknoll · 2021-06-30T20:13:44Z

Remove unnecessary React.Suspense checks, as the minimum supported version is react@>=17.0.1. Also removes some files from the react-18 integration test that are no longer necessary as of #26664.

ijjk · 2021-06-30T20:38:02Z

Failing test suites

Commit: 807e1aa

test/integration/size-limit/test/index.test.js

Production response size > should not increase the overall response size of default build

Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeCloseTo(expected, precision)

Expected: 286.8
Received: 286.2998046875

Expected precision:    0
Expected difference: < 0.5
Received difference:   0.5001953125000114

  86 |
  87 |     // Expected difference: < 0.5
> 88 |     expect(delta).toBeCloseTo(286.8, 0)
     |                   ^
  89 |   })
  90 | })
  91 |

  at Object.<anonymous> (integration/size-limit/test/index.test.js:88:19)

test/integration/react-18/test/index.test.js

React 18 Support > build > prerelease version of React
React 18 Support > dev > prerelease version of React

Expand output

● React 18 Support › build › prerelease version of React

expect(received).toMatch(expected)

Expected substring: "Using the createRoot API for React"
Received string:    "info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
info  - Checking validity of types...
info  - Creating an optimized production build...
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/3)
info  - Generating static pages (3/3)
info  - Finalizing page optimization...·
Page                             Size     First Load JS
┌ ○ /                            280 B          65.7 kB
└ ○ /404                         3.18 kB        68.6 kB
+ First Load JS shared by all    65.5 kB
  ├ chunks/framework.4ef46b.js   1.96 kB
  ├ chunks/main.2c17bc.js        61.9 kB
  ├ chunks/pages/_app.63d6df.js  801 B
  └ chunks/webpack.672781.js     766 B·
λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
○  (Static)  automatically rendered as static HTML (uses no initial props)
●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
   (ISR)     incremental static regeneration (uses revalidate in getStaticProps)·
"

  59 |     test('prerelease version of React', async () => {
  60 |       const output = await getBuildOutput(dirPrerelease)
> 61 |       expect(output).toMatch(USING_CREATE_ROOT)
     |                      ^
  62 |       expect(output).toMatch(UNSUPPORTED_PRERELEASE)
  63 |     })
  64 |   })

  at Object.<anonymous> (integration/react-18/test/index.test.js:61:22)

● React 18 Support › dev › prerelease version of React

expect(received).toMatch(expected)

Expected substring: "Using the createRoot API for React"
Received string:    "ready - started server on 0.0.0.0:39805, url: http://localhost:39805
info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
event - compiled successfully
"

  73 |     test('prerelease version of React', async () => {
  74 |       let output = await getDevOutput(dirPrerelease)
> 75 |       expect(output).toMatch(USING_CREATE_ROOT)
     |                      ^
  76 |       expect(output).toMatch(UNSUPPORTED_PRERELEASE)
  77 |     })
  78 |   })

  at Object.<anonymous> (integration/react-18/test/index.test.js:75:22)

ijjk · 2021-08-02T18:45:44Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
buildDuration	13.8s	13.6s	-131ms
buildDurationCached	3.2s	3.1s	-163ms
nodeModulesSize	50 MB	50 MB	-2.28 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.325	2.313	-0.01
/ avg req/sec	1075.49	1080.74	+5.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.342	1.285	-0.06
/error-in-render avg req/sec	1863.23	1945.55	+82.32

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	22.8 kB	22.8 kB	✓
webpack-HASH.js gzip	1.5 kB	1.5 kB	✓
Overall change	66.7 kB	66.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
_app-HASH.js gzip	980 B	980 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.52 kB	2.52 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
image-HASH.js gzip	4.1 kB	4.1 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	319 B	319 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	12.8 kB	12.8 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
_buildManifest.js gzip	490 B	490 B	✓
Overall change	490 B	490 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
index.html gzip	530 B	530 B	✓
link.html gzip	542 B	542 B	✓
withRouter.html gzip	524 B	524 B	✓
Overall change	1.6 kB	1.6 kB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
buildDuration	10.9s	11s	⚠️ +56ms
buildDurationCached	4.3s	4.3s	-14ms
nodeModulesSize	50 MB	50 MB	-2.28 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.333	2.331	0
/ avg req/sec	1071.5	1072.68	+1.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.344	1.316	-0.03
/error-in-render avg req/sec	1860.33	1899.08	+38.75

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
17.HASH.js gzip	185 B	185 B	✓
677f882d2ed8..HASH.js gzip	13.8 kB	13.8 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.6 kB	10.6 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	67.7 kB	67.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
_app-HASH.js gzip	965 B	965 B	✓
_error-HASH.js gzip	3.74 kB	3.74 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.71 kB	2.71 kB	✓
head-HASH.js gzip	2.97 kB	2.97 kB	✓
hooks-HASH.js gzip	911 B	911 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	2.94 kB	2.94 kB	✓
withRouter-HASH.js gzip	294 B	294 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	17.7 kB	17.7 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
_buildManifest.js gzip	499 B	499 B	✓
Overall change	499 B	499 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js remove-suspense-check	Change
index.html gzip	578 B	578 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	571 B	571 B	✓
Overall change	1.74 kB	1.74 kB	✓

Commit: bff71e6

Remove unnecessary `React.Suspense` checks, as the minimum supported version is `react@>=17.0.1`. Also removes some files from the `react-18` integration test that are no longer necessary as of vercel#26664.

More React 17 clean up

807e1aa

ijjk added created-by: Chrome Aurora type: next labels Jun 30, 2021

timneutkens previously approved these changes Jul 1, 2021

View reviewed changes

Merge branch 'canary' into remove-suspense-check

cdcd8bf

devknoll dismissed timneutkens’s stale review via d1b2909 August 2, 2021 15:52

devknoll force-pushed the remove-suspense-check branch 3 times, most recently from 2afa76e to 6a1bc9c Compare August 2, 2021 15:59

devknoll added 2 commits August 2, 2021 16:06

Add back required files

5bff898

Merge branch 'canary' into remove-suspense-check

17fb571

devknoll force-pushed the remove-suspense-check branch from 6a1bc9c to 17fb571 Compare August 2, 2021 16:06

This comment has been minimized.

Sign in to view

devknoll added 2 commits August 2, 2021 17:33

Merge branch 'canary' into remove-suspense-check

4b1ac98

Remove old unit test

a1b63e7

This comment has been minimized.

Sign in to view

Merge branch 'canary' into remove-suspense-check

bff71e6

devknoll marked this pull request as ready for review August 2, 2021 18:35

devknoll requested review from huozhi, ijjk, padmaia, shuding and styfle as code owners August 2, 2021 18:35

ijjk approved these changes Aug 2, 2021

View reviewed changes

kodiakhq bot merged commit 79e30f9 into vercel:canary Aug 2, 2021

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More React 17 clean up #26775

More React 17 clean up #26775

devknoll commented Jun 30, 2021

ijjk commented Jun 30, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 2, 2021

More React 17 clean up #26775

More React 17 clean up #26775

Conversation

devknoll commented Jun 30, 2021

ijjk commented Jun 30, 2021 • edited Loading

Failing test suites

This comment has been minimized.

This comment has been minimized.

ijjk commented Aug 2, 2021

Stats from current PR

ijjk commented Jun 30, 2021 •

edited

Loading