-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESLint] Removes image rule as error in Core Web Vitals config #26967
Merged
timneutkens
merged 2 commits into
vercel:canary
from
housseindjirdeh:eslint-remove-image-eslint-rule
Jul 8, 2021
Merged
[ESLint] Removes image rule as error in Core Web Vitals config #26967
timneutkens
merged 2 commits into
vercel:canary
from
housseindjirdeh:eslint-remove-image-eslint-rule
Jul 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
requested review from
huozhi,
ijjk,
padmaia,
shuding,
styfle and
timneutkens
as code owners
July 6, 2021 17:47
ijjk
added
the
created-by: Chrome Aurora
PRs by the Google Chrome team: https://web.dev/aurora
label
Jul 6, 2021
leerob
approved these changes
Jul 6, 2021
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
buildDuration | 13.3s | 12.9s | -390ms |
buildDurationCached | 3.2s | 3.1s | -69ms |
nodeModulesSize | 49.3 MB | 49.3 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.316 | 2.317 | 0 |
/ avg req/sec | 1079.4 | 1078.92 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.322 | 1.279 | -0.04 |
/error-in-render avg req/sec | 1891.57 | 1953.91 | +62.34 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
359.HASH.js gzip | 3.09 kB | 3.09 kB | ✓ |
framework-HASH.js gzip | 42 kB | 42 kB | ✓ |
main-HASH.js gzip | 20.6 kB | 20.6 kB | ✓ |
webpack-HASH.js gzip | 1.49 kB | 1.49 kB | ✓ |
Overall change | 67.2 kB | 67.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
_app-HASH.js gzip | 803 B | 803 B | ✓ |
_error-HASH.js gzip | 3.18 kB | 3.18 kB | ✓ |
amp-HASH.js gzip | 526 B | 526 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
hooks-HASH.js gzip | 903 B | 903 B | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.65 kB | 1.65 kB | ✓ |
routerDirect..HASH.js gzip | 322 B | 322 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 8.42 kB | 8.42 kB | ✓ |
Client Build Manifests
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
_buildManifest.js gzip | 390 B | 390 B | ✓ |
Overall change | 390 B | 390 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
index.html gzip | 523 B | 523 B | ✓ |
link.html gzip | 537 B | 537 B | ✓ |
withRouter.html gzip | 515 B | 515 B | ✓ |
Overall change | 1.57 kB | 1.57 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
buildDuration | 11.1s | 11.7s | |
buildDurationCached | 4.6s | 4.6s | -51ms |
nodeModulesSize | 49.3 MB | 49.3 MB | ✓ |
Page Load Tests Overall increase ✓
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.311 | 2.309 | 0 |
/ avg req/sec | 1081.86 | 1082.54 | +0.68 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.29 | 1.266 | -0.02 |
/error-in-render avg req/sec | 1937.84 | 1974.5 | +36.66 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
14.HASH.js gzip | 3.11 kB | 3.11 kB | ✓ |
677f882d2ed8..HASH.js gzip | 13.9 kB | 13.9 kB | ✓ |
framework.HASH.js gzip | 41.8 kB | 41.8 kB | ✓ |
main-HASH.js gzip | 7.81 kB | 7.81 kB | ✓ |
webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
Overall change | 67.8 kB | 67.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
_app-HASH.js gzip | 791 B | 791 B | ✓ |
_error-HASH.js gzip | 3.83 kB | 3.83 kB | ✓ |
amp-HASH.js gzip | 531 B | 531 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
hooks-HASH.js gzip | 910 B | 910 B | ✓ |
index-HASH.js gzip | 227 B | 227 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 295 B | 295 B | ✓ |
withRouter-HASH.js gzip | 292 B | 292 B | ✓ |
e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
Overall change | 8.98 kB | 8.98 kB | ✓ |
Client Build Manifests
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
_buildManifest.js gzip | 418 B | 418 B | ✓ |
Overall change | 418 B | 418 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | housseindjirdeh/next.js eslint-remove-image-eslint-rule | Change | |
---|---|---|---|
index.html gzip | 569 B | 569 B | ✓ |
link.html gzip | 581 B | 581 B | ✓ |
withRouter.html gzip | 561 B | 561 B | ✓ |
Overall change | 1.71 kB | 1.71 kB | ✓ |
timneutkens
approved these changes
Jul 8, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
…l#26967) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple instances of the
<Image>
component not working as well as it should due to some underlying performance issues. Until those issues are resolved, this PR removes recommending its usage over an<img>
tag it as an ESLint error in thenext/core-web-vitals
config. It will only display as a warning.