Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant ssr option for styled-components #27221

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Remove redundant ssr option for styled-components #27221

merged 2 commits into from
Jul 19, 2021

Conversation

brandonchinn178
Copy link
Contributor

This was added in #6001 to fix an issue, but it turns out it was redundant anyway since the option defaults to true (mentioned here: #5988 (comment)).

Docs:

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 16, 2021
leerob
leerob previously approved these changes Jul 16, 2021
@brandonchinn178
Copy link
Contributor Author

@ijjk it seems like those failures are unrelated to my PR? Its just showing changes to the url

@ijjk ijjk changed the base branch from master to canary July 19, 2021 19:16
@ijjk ijjk dismissed leerob’s stale review July 19, 2021 19:16

The base branch was changed.

@ijjk ijjk requested review from huozhi, padmaia and styfle as code owners July 19, 2021 19:16
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 7fea8f3 into vercel:canary Jul 19, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants