-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fauna example with new guestbook #27295
Conversation
I'm having trouble getting the setup script to run. Just me? |
5b74e50
to
fddc4d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like lint is failing - could you please fix that and then we can merge?
examples/with-fauna/package.json
Outdated
"react": "^17.0.2", | ||
"react-dom": "^17.0.2", | ||
"request": "2.88.2", | ||
"stream-to-promise": "3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be moved to devDep?
I've actually found a few places referencing the old example before being renamed - could you add a simple README to the old folder saying it's moved to |
6838084
to
0ccc25e
Compare
Based on vercel#26708 - Renames FaunaDB -> Fauna - Moves to Tailwind instead of bespoke styling - Use SWR instead of hand-rolled fetch wrapper - List/Create API for Guestbook - Preps for setting correct environment variables from Vercel integration
Based on #26708