Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fauna example with new guestbook #27295

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

artem-kurnikov
Copy link
Contributor

Based on #26708

  • Renames FaunaDB -> Fauna
  • Moves to Tailwind instead of bespoke styling
  • Use SWR instead of hand-rolled fetch wrapper
  • List/Create API for Guestbook
  • Preps for setting correct environment variables from Vercel integration

@leerob
Copy link
Member

leerob commented Jul 21, 2021

I'm having trouble getting the setup script to run. Just me?

@artem-kurnikov artem-kurnikov force-pushed the with-fauna-example branch 2 times, most recently from 5b74e50 to fddc4d6 Compare July 30, 2021 13:11
leerob
leerob previously approved these changes Aug 2, 2021
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint is failing - could you please fix that and then we can merge?

"react": "^17.0.2",
"react-dom": "^17.0.2",
"request": "2.88.2",
"stream-to-promise": "3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved to devDep?

@leerob
Copy link
Member

leerob commented Aug 2, 2021

I've actually found a few places referencing the old example before being renamed - could you add a simple README to the old folder saying it's moved to with-fauna?

@kodiakhq kodiakhq bot merged commit fe3f520 into vercel:canary Aug 2, 2021
@artem-kurnikov artem-kurnikov deleted the with-fauna-example branch August 3, 2021 11:47
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
Based on vercel#26708

- Renames FaunaDB -> Fauna
- Moves to Tailwind instead of bespoke styling
- Use SWR instead of hand-rolled fetch wrapper
- List/Create API for Guestbook
- Preps for setting correct environment variables from Vercel integration
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants