Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swc for mac m1 compiling issue #27329

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jul 20, 2021

@swc/core will trigger a very rare complication issue on mac m1, it's fixed in version 1.2.66

x-ref: swc-project/swc#1939
x-ref: napi-rs/napi-rs#654
cc @kdy1

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jul 20, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jul 20, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js upgrade-swc Change
buildDuration 12.8s 12.9s ⚠️ +115ms
buildDurationCached 3s 3s -29ms
nodeModulesSize 49.5 MB 49.5 MB -168 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js upgrade-swc Change
/ failed reqs 0 0
/ total time (seconds) 2.084 2.079 0
/ avg req/sec 1199.35 1202.68 +3.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.121 1.126 0
/error-in-render avg req/sec 2229.56 2219.51 ⚠️ -10.05
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-swc Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 20.9 kB 20.9 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.8 kB 67.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-swc Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-swc Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.61 kB 5.61 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-swc Change
_buildManifest.js gzip 490 B 490 B
Overall change 490 B 490 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-swc Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 523 B 523 B
Overall change 1.59 kB 1.59 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary huozhi/next.js upgrade-swc Change
buildDuration 10.5s 9.8s -703ms
buildDurationCached 3.9s 3.6s -246ms
nodeModulesSize 49.5 MB 49.5 MB -168 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js upgrade-swc Change
/ failed reqs 0 0
/ total time (seconds) 2.081 2.031 -0.05
/ avg req/sec 1201.45 1230.88 +29.43
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.035 1.078 ⚠️ +0.04
/error-in-render avg req/sec 2415.13 2319.95 ⚠️ -95.18
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js upgrade-swc Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.4 kB 68.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js upgrade-swc Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary huozhi/next.js upgrade-swc Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js upgrade-swc Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js upgrade-swc Change
index.html gzip 577 B 577 B
link.html gzip 588 B 588 B
withRouter.html gzip 570 B 570 B
Overall change 1.74 kB 1.74 kB
Commit: eb609fb

@kodiakhq kodiakhq bot merged commit 41b4fc3 into vercel:canary Jul 20, 2021
@huozhi huozhi deleted the upgrade-swc branch July 20, 2021 14:21
@Janpot
Copy link
Contributor

Janpot commented Jul 20, 2021

@huozhi Awesome, came here to update on the Next.js repo after reporting it. Happy to find it already been taken care of 👍

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
`@swc/core` will trigger a very rare complication issue on mac m1, it's fixed in version 1.2.66
x-ref: swc-project/swc#1939

cc @kdy1 

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants