Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint config options to NextConfig type #27446

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

stefanprobst
Copy link
Contributor

This adds missing eslint config options to the public NextConfig type.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 23, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
buildDuration 13s 12.7s -342ms
buildDurationCached 3s 2.8s -160ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +548 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
/ failed reqs 0 0
/ total time (seconds) 2.116 2.061 -0.06
/ avg req/sec 1181.7 1213.24 +31.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.193 1.218 ⚠️ +0.02
/error-in-render avg req/sec 2096.32 2053.27 ⚠️ -43.05
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 21 kB 21 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.63 kB 5.63 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
buildDuration 9.9s 10.6s ⚠️ +675ms
buildDurationCached 3.9s 4s ⚠️ +62ms
nodeModulesSize 49.5 MB 49.5 MB ⚠️ +548 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
/ failed reqs 0 0
/ total time (seconds) 2.107 2.225 ⚠️ +0.12
/ avg req/sec 1186.32 1123.5 ⚠️ -62.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.192 1.251 ⚠️ +0.06
/error-in-render avg req/sec 2098.17 1997.94 ⚠️ -100.23
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.5 kB 68.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js fix/next-config-type-eslint Change
index.html gzip 577 B 577 B
link.html gzip 589 B 589 B
withRouter.html gzip 569 B 569 B
Overall change 1.74 kB 1.74 kB
Commit: 66654ef

@kodiakhq kodiakhq bot merged commit 046f716 into vercel:canary Jul 23, 2021
@stefanprobst stefanprobst deleted the fix/next-config-type-eslint branch July 23, 2021 19:17
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
This adds missing eslint config options to the public `NextConfig` type.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
kodiakhq bot pushed a commit that referenced this pull request Aug 24, 2021
This is similar to #27126 , #27446 and #27974

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants