Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --dev flag to bundle-analyzer install command #27463

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Add --dev flag to bundle-analyzer install command #27463

merged 1 commit into from
Jul 25, 2021

Conversation

gnbaron
Copy link
Contributor

@gnbaron gnbaron commented Jul 24, 2021

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Jul 24, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
buildDuration 13.1s 13s -139ms
buildDurationCached 3s 3s -53ms
nodeModulesSize 49.5 MB 49.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.195 2.156 -0.04
/ avg req/sec 1139.07 1159.41 +20.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.228 1.228 ✓
/error-in-render avg req/sec 2036.37 2035.9 ⚠️ -0.47
Client Bundles (main, webpack, commons)
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
359.HASH.js gzip 2.96 kB 2.96 kB ✓
745.HASH.js gzip 180 B 180 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 21 kB 21 kB ✓
webpack-HASH.js gzip 1.53 kB 1.53 kB ✓
Overall change 67.9 kB 67.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
_app-HASH.js gzip 803 B 803 B ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 554 B 554 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.52 kB 2.52 kB ✓
head-HASH.js gzip 2.28 kB 2.28 kB ✓
hooks-HASH.js gzip 903 B 903 B ✓
image-HASH.js gzip 5.63 kB 5.63 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 19.1 kB 19.1 kB ✓
Client Build Manifests
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
_buildManifest.js gzip 489 B 489 B ✓
Overall change 489 B 489 B ✓
Rendered Page Sizes
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
index.html gzip 531 B 531 B ✓
link.html gzip 542 B 542 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
buildDuration 10.3s 10.4s ⚠️ +93ms
buildDurationCached 4s 4s -1ms
nodeModulesSize 49.5 MB 49.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.279 2.21 -0.07
/ avg req/sec 1097.02 1131.26 +34.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.215 1.219 0
/error-in-render avg req/sec 2057.84 2051.28 ⚠️ -6.56
Client Bundles (main, webpack, commons)
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
17.HASH.js gzip 2.98 kB 2.98 kB ✓
18.HASH.js gzip 185 B 185 B ✓
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 8.4 kB 8.4 kB ✓
webpack-HASH.js gzip 1.22 kB 1.22 kB ✓
Overall change 68.5 kB 68.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
_app-HASH.js gzip 791 B 791 B ✓
_error-HASH.js gzip 3.76 kB 3.76 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 2.97 kB 2.97 kB ✓
hooks-HASH.js gzip 911 B 911 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.02 kB 3.02 kB ✓
withRouter-HASH.js gzip 294 B 294 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 17.6 kB 17.6 kB ✓
Client Build Manifests
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary gnbaron/next.js docs-@next/bundle-analyzer Change
index.html gzip 576 B 576 B ✓
link.html gzip 588 B 588 B ✓
withRouter.html gzip 569 B 569 B ✓
Overall change 1.73 kB 1.73 kB ✓
Commit: 0db5e25

@kodiakhq kodiakhq bot merged commit 0d49d9f into vercel:canary Jul 25, 2021
@ijjk ijjk mentioned this pull request Jul 26, 2021
Merged
1 task
kodiakhq bot pushed a commit that referenced this pull request Jul 26, 2021
@ijjk
Update bundle analyzer readme (#27507)
b25a983 
Follow-up to #27463 this adds a note about installing as `devDependency` instead of changing the default install command as the plugin being a `devDependency` might cause issues unless wrapped in a `process.env` check. 


## Documentation / Examples

- [x] Make sure the linting passes
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@gnbaron
Add --dev flag to bundle-analyzer install command (vercel#27463)
d3ddc93 
## Documentation / Examples

- [x] Make sure the linting passes
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@ijjk
Update bundle analyzer readme (vercel#27507)
484d9f6 
Follow-up to vercel#27463 this adds a note about installing as `devDependency` instead of changing the default install command as the plugin being a `devDependency` might cause issues unless wrapped in a `process.env` check. 


## Documentation / Examples

- [x] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnbaron @ijjk