Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ts template readme api/index file extension from tsx to ts #27485

Merged

Conversation

noahweingand
Copy link
Contributor

@noahweingand noahweingand commented Jul 25, 2021

Documentation / Examples

  • Make sure the linting passes

Changes

  • Corrected the file extension reference from .tsx to .ts for packages/create-next-app/templates/typescript/README-template.md.
    This matches the actual file extension and avoids confusion for new users.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jul 25, 2021
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Jul 25, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
buildDuration 15.1s 14.7s -466ms
buildDurationCached 3.3s 3.2s -108ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
/ failed reqs 0 0
/ total time (seconds) 2.477 2.507 ⚠️ +0.03
/ avg req/sec 1009.12 997.2 ⚠️ -11.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.373 1.392 ⚠️ +0.02
/error-in-render avg req/sec 1820.66 1795.78 ⚠️ -24.88
Client Bundles (main, webpack, commons)
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
359.HASH.js gzip 2.96 kB 2.96 kB
745.HASH.js gzip 180 B 180 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 21 kB 21 kB
webpack-HASH.js gzip 1.53 kB 1.53 kB
Overall change 67.9 kB 67.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
_app-HASH.js gzip 803 B 803 B
_error-HASH.js gzip 3.06 kB 3.06 kB
amp-HASH.js gzip 554 B 554 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.52 kB 2.52 kB
head-HASH.js gzip 2.28 kB 2.28 kB
hooks-HASH.js gzip 903 B 903 B
image-HASH.js gzip 5.63 kB 5.63 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 319 B 319 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.1 kB 19.1 kB
Client Build Manifests
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
_buildManifest.js gzip 489 B 489 B
Overall change 489 B 489 B
Rendered Page Sizes
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
index.html gzip 531 B 531 B
link.html gzip 542 B 542 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Webpack 4 Mode (Increase detected ⚠️)
General
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
buildDuration 12s 11.9s -128ms
buildDurationCached 4.8s 4.6s -221ms
nodeModulesSize 49.5 MB 49.5 MB
Page Load Tests Overall increase ✓
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
/ failed reqs 0 0
/ total time (seconds) 2.51 2.469 -0.04
/ avg req/sec 995.91 1012.7 +16.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.431 1.365 -0.07
/error-in-render avg req/sec 1747.62 1831.54 +83.92
Client Bundles (main, webpack, commons)
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
17.HASH.js gzip 2.98 kB 2.98 kB
18.HASH.js gzip 185 B 185 B
677f882d2ed8..HASH.js gzip 13.8 kB 13.8 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 8.4 kB 8.4 kB
webpack-HASH.js gzip 1.22 kB 1.22 kB
Overall change 68.5 kB 68.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
_app-HASH.js gzip 791 B 791 B
_error-HASH.js gzip 3.76 kB 3.76 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 2.97 kB 2.97 kB
hooks-HASH.js gzip 911 B 911 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.02 kB 3.02 kB
withRouter-HASH.js gzip 294 B 294 B
e025d2764813..52f.css gzip 125 B 125 B
Overall change 17.6 kB 17.6 kB
Client Build Manifests
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary noahweingand/next.js noahweingand/next.js/ts-readme-typo Change
index.html gzip 576 B 576 B
link.html gzip 588 B 588 B
withRouter.html gzip 569 B 569 B
Overall change 1.73 kB 1.73 kB
Commit: 631e3df

@kodiakhq kodiakhq bot merged commit 84b71c3 into vercel:canary Jul 25, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
…rcel#27485)

## Documentation / Examples

- [x] Make sure the linting passes

### Changes
* Corrected the file extension reference from .tsx to .ts for ```packages/create-next-app/templates/typescript/README-template.md```. 
This matches the actual file extension and avoids confusion for new users.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants